Git Product home page Git Product logo

Comments (6)

goessner avatar goessner commented on September 26, 2024

yes ... I agree. I also stumbled yesterday over that bug and intended to raise an issue also,

But there is no need for a new Object method, as Object.assign works identically to the alternate spread syntax.

See this link for a recent discussion of PWA's.

from g2.

klawr avatar klawr commented on September 26, 2024

Should be polyfilled for Edge now.
If any issues occur please let me know.

from g2.

goessner avatar goessner commented on September 26, 2024

For example in line 82 ...

 g.beg(Object.assign({}, {x:this.x,y:this.y,lw:1}, this.defaults.style,this.style));

there is no need to have that empty object in the beginning, as the the second one can be modified as destination, as in

 g.beg(Object.assign({x:this.x,y:this.y,lw:1}, this.defaults.style,this.style));

This should be less memory intensive and more performant.

from g2.

klawr avatar klawr commented on September 26, 2024

I actually do think the difference can't be measured, or the JIT-Compiler would optimize this part anyway.
Anyway i changed this in 6a68bc3

from g2.

jauhl avatar jauhl commented on September 26, 2024

Thanks, works now.

Although there is still some spreading going on in g2.core.js (e.g. here or here), it doesnโ€™t seem to be a problem for mecEdit for now.

Maybe you can still get rid of those too, in the future.

from g2.

klawr avatar klawr commented on September 26, 2024

This should be no problem.
In line 473 a rest parameter is used, which looks like a spread-operator, but is none.
The others are supported in Edge, since they are function-calls and not object-literals.

Let me know in case I missed one.

from g2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.