Comments (6)
yes ... I agree. I also stumbled yesterday over that bug and intended to raise an issue also,
But there is no need for a new Object
method, as Object.assign
works identically to the alternate spread syntax.
See this link for a recent discussion of PWA's.
from g2.
Should be polyfilled for Edge now.
If any issues occur please let me know.
from g2.
For example in line 82 ...
g.beg(Object.assign({}, {x:this.x,y:this.y,lw:1}, this.defaults.style,this.style));
there is no need to have that empty object in the beginning, as the the second one can be modified as destination, as in
g.beg(Object.assign({x:this.x,y:this.y,lw:1}, this.defaults.style,this.style));
This should be less memory intensive and more performant.
from g2.
I actually do think the difference can't be measured, or the JIT-Compiler would optimize this part anyway.
Anyway i changed this in 6a68bc3
from g2.
Thanks, works now.
Although there is still some spreading going on in g2.core.js
(e.g. here or here), it doesnโt seem to be a problem for mecEdit for now.
Maybe you can still get rid of those too, in the future.
from g2.
This should be no problem.
In line 473 a rest parameter is used, which looks like a spread-operator, but is none.
The others are supported in Edge, since they are function-calls and not object-literals.
Let me know in case I missed one.
from g2.
Related Issues (20)
- mec documentation missing most symbols HOT 8
- pulley2 angle not working HOT 1
- g2.ext.md
- g2 chart HOT 1
- mec pulley() bug? HOT 1
- .exe() not chainable HOT 1
- tests for extensions are in old repositories HOT 1
- symbols documentation
- truss example missing bar labels ... HOT 1
- g2.editor.js should be removed ...
- State and Style example ... HOT 1
- 'format' property for 'ply' command
- remove usage of Map in g2.core
- .img() parameters HOT 3
- 'scl' property of 'img' disappeared HOT 8
- 'ins' command should accept 'g2' objects
- chart-element samples missing HOT 2
- chart-element should reside in dist folder HOT 1
- xmin, xmax in chart do not work properly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from g2.