Git Product home page Git Product logo

Comments (1)

fjarrett avatar fjarrett commented on July 18, 2024 1

@schrapel I purposely removed this behavior for the following reasons:

  1. It wasn't future-proof. Always outputting the custom CSS gives us the option to change the default colors in a theme update down the road without affecting existing users of that theme. It will be a poor experience if update their theme and the front-end colors change without warning. This way whatever they have their swatches saved as in the Customizer will always be what is displayed on their site.
  2. It prevents people from filtering defaults because there the style.css will not match. For example, if a user wants to change the default color in their child theme (for whatever reason) they can simply filter the primer_colors array. However if the color is not also manually updated in the style.css file, the default would not display correctly.

from primer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.