Git Product home page Git Product logo

Comments (6)

tobeycodes avatar tobeycodes commented on July 1, 2024

This is useful for at least running once. Would be clever if we could just pass a color such as #fff and it would match it and return all the occurrences whether it was #fff or #ffffff and whether it was in a border, background, color, etc

from primer.

fjarrett avatar fjarrett commented on July 1, 2024

Yep, that's exactly what I'm doing.

from primer.

fjarrett avatar fjarrett commented on July 1, 2024

Well, I actually got this working, but there is a giant caveat:

_No two colors can have the same default value._

This is potentially a deal-breaker. I am going to think on this one for a bit...

from primer.

tobeycodes avatar tobeycodes commented on July 1, 2024

Yeah, that's a problem. None of them use same colours now so it could be useful to speed up development now if we can dump them out but perhaps not something we bundle in the theme.

If they have the same colors surely the css output is the same though. It only becomes a problem when you then change the colors and you need to know which go with which color. tough one

from primer.

fjarrett avatar fjarrett commented on July 1, 2024

The simplest work-around would be to change the last character in HEX values so colors are always unique but not noticeable to the naked eye.

from primer.

fjarrett avatar fjarrett commented on July 1, 2024

I'm giving up on this for now. May resurrect at a later time as a tool to aid developers, but for now all rules need to still be passed manually via the filter. There are too many edge cases to an automated solution.

from primer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.