Comments (8)
fjarrett
commented on July 18, 2024
@jonathanbardo Looks like there is already a little explanation in the UI for this. Are you thinking of maybe making the message more prominent if you don't have a three-column layout selected?
from primer.
jonathanbardo
commented on July 18, 2024
@fjarrett Actually I don't we didn't have a message. This is fine with me we can close this.
from primer.
samonja
commented on July 18, 2024
How do I change the default post/page layout to full width. Thanks
from primer.
fjarrett
commented on July 18, 2024
Hi @samonja - You can use the primer_default_layout filter defined here, and just return the key of any available layout listed here.
add_filter( 'primer_default_layout', function () {
return 'one-column-wide';
} );from primer.
samonja
commented on July 18, 2024
Is this how it suppose to look ... because I did that and nothing happen
/**
* Filter the default layout.
*
* @SInCE 1.0.0
*
* @var string
*/
$default = (string) apply_filters( 'primer_default_layout', $this->default );
$this->default = $this->layout_exists( $default ) ? $default : ( $this->layout_exists( $this->default ) ? $this->default : key( $this->layouts ) );
add_filter( 'primer_default_layout', function () {
return 'one-column-wide';
} );
/**
* Filter if post/page overrides via meta box should be enabled.
*
* @SInCE 1.0.0
*
* @var bool
*/
Sent from Outlook<http://aka.ms/weboutlook>
…________________________________
From: Frankie Jarrett <[email protected]>
Sent: Saturday, December 31, 2016 3:11 AM
To: godaddy/wp-primer-theme
Cc: samonja; Mention
Subject: Re: [godaddy/wp-primer-theme] Improve UX for secondary sidebars (#36)
Hi @samonja<https://github.com/samonja> - You can use the primer_default_layout filter defined here<https://github.com/godaddy/wp-primer-theme/blob/5d4070b8087469dc19057731b463b29f37763379/inc/customizer/layouts.php#L76>, and just return the key of any available layout listed here<https://github.com/godaddy/wp-primer-theme/blob/5d4070b8087469dc19057731b463b29f37763379/inc/customizer/layouts.php#L51-L60>.
add_filter( 'primer_default_layout', function () {
return 'one-column-wide';
} );
-
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#36 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOMJxMqNL3ZzHhWOu88nucQIIi0eQW-wks5rNg5FgaJpZM4JWaCG>.
from primer.
fjarrett
commented on July 18, 2024
Hey @samonja - you never want to modify theme files directly, they will be wiped out each time the theme receives an update. Filters should be added to your own child theme or a must-use plugin.
If filters are new to you, this is a good article to learn about how they work.
Thanks for using Primer!
from primer.
samonja
commented on July 18, 2024
I know that. I have a child team. I want to know where to access the <wp_header> file.
Sent from Outlook<http://aka.ms/weboutlook>
…________________________________
From: Frankie Jarrett <[email protected]>
Sent: Saturday, December 31, 2016 4:47 PM
To: godaddy/wp-primer-theme
Cc: samonja; Mention
Subject: Re: [godaddy/wp-primer-theme] Improve UX for secondary sidebars (#36)
Hey @samonja<https://github.com/samonja> - you never want to modify theme files directly, they will be wiped out each time the theme receives an update. Filters should be added to your own child theme<https://codex.wordpress.org/Child_Themes> or a must-use plugin<https://codex.wordpress.org/Must_Use_Plugins>.
If filters are new to you, this is a good article<http://dev.themeblvd.com/tutorial/filters/> to learn about how they work.
Thanks for using Primer!
-
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#36 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOMJxFfwCDRfETMy-dSjwH1RqEWYxY8Gks5rNs2OgaJpZM4JWaCG>.
from primer.
fjarrett
commented on July 18, 2024
@samonja In your example it appears you are editing the theme directly, and that's part of the reason why it's not working :-)
The add_filter must always be called before it's defined with apply_filters, hence the reason for it to be done in a child theme or must-use plugin because they are loaded before parent themes.
Not sure what you mean about the header file.
from primer.
Related Issues (20)
- Update php version with php 7+ HOT 2
- Fix Susy 3.0+ mixin errors
- ISBAT see the editor width change based on the selected page layout HOT 3
- ISBAT experience the CoBlocks form block as styled on the front-end HOT 1
- Primer theme update to 1.8.7 breaks Blubrry plugin on PHP version 7.x when trying to upload media. Popup displays WordPress 500 ISE. HOT 1
- Uninstall button missing HOT 1
- Add support for the wp_body_open hook HOT 1
- Post area 100% height HOT 1
- Not compatible with latest wordpress version HOT 3
- Javascript error during page edit after upgrading from WordPress 5.2.4 to 5.3 HOT 1
- WooCommerce theme overrides featured-image header setting HOT 2
- Primer wp theme problem
- Sidebar doesn't scroll HOT 1
- On WordPress 5.5 and Gutenberg editor, the background color in editor is no longer inherited(works fine in WP 5.4.2) HOT 1
- Video in header not showing on mobile - Uptown Style HOT 4
- Images and text in Gutenberg have differences in sizing compaired to the default theme. HOT 1
- Choose whether to display Secondary Sidebar Widget on mobile devices HOT 1
- Adding a preload feature for randomized header image HOT 1
- Add support for non-Google fonts HOT 2
- Videos not working on mobile and also Safari HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from primer.