Comments (3)
tobeycodes
commented on July 18, 2024
Now I made it so the site-title isn't forced to take up the entire header. We should strip back the navigation too. We could then more easily move the navigation from below the header region to inside it.
from primer.
tobeycodes
commented on July 18, 2024
I've just pushed up a rewrite of the navigation (596859f)
- The
menu-togglecan now be outside of thesite-navigationcontainer - Show grand children on mobile with additional padding (hidden before)
- Only mobile first with a breakpoint at 600px (as before)
- The menu is no longer forced to take up the entire container, so easy to use multiple menus
If we want to introduce clickable dropdowns for children on mobile we will need to add a <span> in each element with the arrow since you before/after is not part of the DOM.
Pretty happy about this part, it was bugging me before how hard the SCSS was to change.
@fjarrett @chriswallace please review
from primer.
fjarrett
commented on July 18, 2024
I'm happy with this.
from primer.
Related Issues (20)
- Update php version with php 7+ HOT 2
- Fix Susy 3.0+ mixin errors
- ISBAT see the editor width change based on the selected page layout HOT 3
- ISBAT experience the CoBlocks form block as styled on the front-end HOT 1
- Primer theme update to 1.8.7 breaks Blubrry plugin on PHP version 7.x when trying to upload media. Popup displays WordPress 500 ISE. HOT 1
- Uninstall button missing HOT 1
- Add support for the wp_body_open hook HOT 1
- Post area 100% height HOT 1
- Not compatible with latest wordpress version HOT 3
- Javascript error during page edit after upgrading from WordPress 5.2.4 to 5.3 HOT 1
- WooCommerce theme overrides featured-image header setting HOT 2
- Primer wp theme problem
- Sidebar doesn't scroll HOT 1
- On WordPress 5.5 and Gutenberg editor, the background color in editor is no longer inherited(works fine in WP 5.4.2) HOT 1
- Video in header not showing on mobile - Uptown Style HOT 4
- Images and text in Gutenberg have differences in sizing compaired to the default theme. HOT 1
- Choose whether to display Secondary Sidebar Widget on mobile devices HOT 1
- Adding a preload feature for randomized header image HOT 1
- Add support for non-Google fonts HOT 2
- Videos not working on mobile and also Safari HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from primer.