access plan `availability_restrictions` property never returned about lifterlms-rest HOT 3 CLOSED

@eri-trabiccolo I've already confirmed this and written a quick fix locally so I'm not blocked but this could be cleaned up sooner than later for release with the other access plan bug you already fixed

from lifterlms-rest.

@thomasplevy

• Also found that we don't have an availability schema property, but the model's has_availability_restrictions() relies on that. So I'm going to switch the availability based on whether availability_restriction property has been provided.
• Also the availability thing is only for access plans related to courses. I think we should notice this in the documentation (and the schema), and possibly don't return availaibilty_restrictions props for memberships.

Agreed?

from lifterlms-rest.

I think this makes sense @eri-trabiccolo. The property barely seems necessary today and really seems unnecessary with what I'm building right now. So keeping it as you have for backwards compatibility purposes but not requiring users to have to actually update it via REST feels good.

I don't want to take the time to properly deprecated it right now but we can phase out it's usefulness and maybe remove it officially alongside the release of the react stuff I'm working on

from lifterlms-rest.