Comments (3)
@eri-trabiccolo I've already confirmed this and written a quick fix locally so I'm not blocked but this could be cleaned up sooner than later for release with the other access plan bug you already fixed
from lifterlms-rest.
- Also found that we don't have an
availability
schema property, but the model'shas_availability_restrictions()
relies on that. So I'm going to switch theavailability
based on whetheravailability_restriction
property has been provided. - Also the availability thing is only for access plans related to courses. I think we should notice this in the documentation (and the schema), and possibly don't return
availaibilty_restrictions
props for memberships.
Agreed?
from lifterlms-rest.
I think this makes sense @eri-trabiccolo. The property barely seems necessary today and really seems unnecessary with what I'm building right now. So keeping it as you have for backwards compatibility purposes but not requiring users to have to actually update it via REST feels good.
I don't want to take the time to properly deprecated it right now but we can phase out it's usefulness and maybe remove it officially alongside the release of the react stuff I'm working on
from lifterlms-rest.
Related Issues (20)
- access plan `checkout_redirect_forced` property not included in REST resource HOT 1
- Cannot enable access plan `forced_redirect` property
- Creating or Updating access plans when there are 6 (max) plans associated with a course/membership results in errors
- Enrollment status update provides two triggers HOT 3
- Improve github pages (specs) cache busting
- Changing the Parent_ID for a lesson trigger using the API triggers an error HOT 2
- CodeQL Error
- Improve response fields filtering HOT 1
- multiple webhooks, same topic HOT 2
- Avoid fatals when searching for courses/memberships but the query post type parameter is forced to be something else
- Setup webhook automatic retries HOT 2
- Add webhook failure email (and admin?) notice(s)
- In the get enrollments for student API call I think there is an error where the pages available is greater than the actual pages for the paginated call. Happens when the page size is equal to the enrolments. HOT 2
- Try enrolling a user with ID 0 into a course: the current user will be enrolled into the course
- PHP Notice when listing API keys.
- Expose assignments and grades through REST API
- test
- Test
- test
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lifterlms-rest.