Comments (6)
Yes, but AFAIR we didn't found a solution. Feel free to make a PR.
from ws.
Yes, but AFAIR we didn't found a solution. Feel free to make a PR.
Please have a look at: #194
Merry Christmas!
from ws.
Thanks for the info, will take a look shortly. Do you have a fix (even a theoretical) for that btw ?
from ws.
You can fix it by replacing httpWriteHeader(bw, headerHost, u.Host) with the following code:
host := u.Host
if headerHTTP, ok := header.(HandshakeHeaderHTTP); ok {
httpHeaderHTTP := http.Header(headerHTTP)
if v := httpHeaderHTTP.Get(headerHost); v != "" {
host = v
}
}
httpWriteHeader(bw, headerHost, host)
And you need to comment out https://github.com/gobwas/ws/blob/master/http.go#L323-L325.
However, since handshakeheader
is an interface, so I don't think my code is a perfect solution.
My solution is specific to HandshakeHeaderHTTP
type.
I think you should decide how to fix it because this solution is related to this library's design itself.
from ws.
@cristaloleg have you looked at this?
from ws.
Fixed in https://github.com/gobwas/ws/releases/tag/v1.3.2
from ws.
Related Issues (20)
- Question: client example
- EOF error on ws.Upgrade HOT 8
- Is it necessary to use sync.Pool to reuse Reader Object in readData? HOT 1
- Read and Write timeouts? HOT 5
- Handshake.Extentions pointing to a buffer already returned to pbufio.ReaderPool
- State of the package and security updates HOT 6
- Websocket error on Safari HOT 4
- Is WriteServerMessage thread-safe? HOT 9
- json decoder or unmarshaler? HOT 2
- Client-side example? HOT 5
- readme example problem HOT 1
- Correct way to handle continuation frame? HOT 1
- ReadFrame maxs out at 4096 lengths HOT 11
- RSV1 set, FIN not set on control using wsutil HOT 1
- Question - add headers during the upgrade HOT 2
- message rate limiter HOT 1
- Client disconnects on its own due to the 1008 error and EOF error. HOT 8
- Any example for using this library with `gnet`? HOT 5
- I encountered a problem of automatic disconnection after 30 seconds HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ws.