Git Product home page Git Product logo

Comments (4)

BeryJu avatar BeryJu commented on May 11, 2024 2

The only difference is that for the oauth2 provider, redirect URIs are validated against the list, and for a normal logins, only relative URIs are allowed.

But since the redirect comes from the OAuthFulfillmentStage and not the flow executor, this is very easy to add.

from authentik.

BeryJu avatar BeryJu commented on May 11, 2024

Sounds good, do you happen to have a stacktrace where that error is thrown?

The only interesting thing about this could be validating the destination URI, since IIRC the final redirect is done by the FlowExecutor, and not the OAuth Provider

from authentik.

adepto-io avatar adepto-io commented on May 11, 2024

Would the validation of the redirect URI with a custom scheme be any different compared to the HTTPS scheme?

Traceback (most recent call last):
File "/authentik/flows/views.py", line 152, in get
stage_response = self.current_stage_view.get(request, *args, **kwargs)
File "/authentik/providers/oauth2/views/authorize.py", line 264, in get
return redirect(self.create_response_uri())
File "/usr/local/lib/python3.9/site-packages/django/shortcuts.py", line 41, in redirect
return redirect_class(resolve_url(to, *args, **kwargs))
File "/usr/local/lib/python3.9/site-packages/django/http/response.py", line 504, in init
raise DisallowedRedirect("Unsafe redirect to URL with protocol %s" % parsed.scheme)
django.core.exceptions.DisallowedRedirect: Unsafe redirect to URL with protocol 'com.example.app'

from authentik.

Sander0542 avatar Sander0542 commented on May 11, 2024

This seems to be broken again starting with 2024.2.0

image

from authentik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.