Sharing fields between entries about log HOT 7 CLOSED

Hey @sebastianwebber I think I’ve got most of it done already in a local branch, just finalizing how I want to do the stack trace stuff, I’ll let you know if I could use help with anything though :)

from log.

ok @sebastianwebber @Perlence I finally got around to updating this library and it now supports sharing fields between entries!

sorry for how long it took, just be so busy with....everything.

from log.

Hey @Perlence

No you haven't missed anything, when I was designing, I wanted to make sure that log was safe to be called from multiple goroutines and if the Entry was reusable then a possibility exists that someone could call it from multiple goroutines and cause themselves problems.

I do however understand your scenario and could look into creating a Release option or function to tell the Entry not to put itself and fields back into the pool.

Would that be something you'd be interested in.?
eg.

// Calling Release() releases the Entry and all fields from
// being managed by the package...
l := log.WithFields(...).Release()

l.Info(...)

I can't promise anything, but I could look into this sort of functionality.

from log.

Thank you for reply. I really don't want to force you to make decisions that you'll regret later, so everything is completely up to you 😄

I think that while Release allows to log same fields multiple times, it cannot be used to add one-off fields, e.g. some error information, and then log an entry with initial fields, because WithFields adds fields in place. So there could be something like (*Entry) CopyWithFields. But I'd like to see one method that can be used either to fix fields for later use or to copy existing fields into a new Entry.

"Release" also doesn't sound too clear to me, kind of low level, for example I didn't know about entry pool before fields started to "leak" through to other entries when I used context multiple times.

from log.

Thanks for the ideas, let me think about how and if I could achieve this.

CopyWithFields() does seem like a good solution!

It may take me a bit to get to this as I'm adding new things to some of my other packages also, but I will get to this 😄

from log.

@joeybloggs do you need help to implement this feature?

from log.

nice @joeybloggs

For now, i'm using:

...
log := log.WithFields(log.F("key", "value"))

log.Info("bla")
...

from log.