Git Product home page Git Product logo

Comments (3)

imrenagi avatar imrenagi commented on August 13, 2024 2

I'm also wondering the same thing. If I'm not mistaken Spring Boot security also stores these as plain text (CMIIW). Not sure why. Is it by design? But as you said in RFC6819, it says these credentials needs to be hashed or encrypted..

This is the current check

func (m *Manager) GenerateAccessToken(gt oauth2.GrantType, tgr *oauth2.TokenGenerateRequest) (accessToken oauth2.TokenInfo, err error) {
	cli, err := m.GetClient(tgr.ClientID)
	.....
	} else if tgr.ClientSecret != cli.GetSecret() { //here it is
		err = errors.ErrInvalidClient
		return
	}
        .....

And I have an idea for adding a custom secretHandler to the manager:

type ValidateClientSecretHandler func(rawSecret, hashedSecret string) (isValid bool)

So, we can use it by:

func (m *Manager) GenerateAccessToken(gt oauth2.GrantType, tgr *oauth2.TokenGenerateRequest) (accessToken oauth2.TokenInfo, err error) {
	cli, err := m.GetClient(tgr.ClientID)
	.....
	} else if m.ValidateClientSecretHandler(tgr.ClientSecret, cli.GetSecret()) {
		err = errors.ErrInvalidClient
		return
	}
        .....

from oauth2.

kostyay avatar kostyay commented on August 13, 2024

You can already do this:
Server already has a method called SetClientInfoHandler
ClientInfoHandler is this:
ClientInfoHandler func(r *http.Request) (clientID, clientSecret string, err error)

You can implement your own ClientInfoHandler that would return the encrypted secret from the request.

The default handler is this:

func ClientBasicHandler(r *http.Request) (string, string, error) {
	username, password, ok := r.BasicAuth()
	if !ok {
		return "", "", errors.ErrInvalidClient
	}
	return username, password, nil
}

so you can implement your own

func MyClientBasicHandler(r *http.Request) (string, string, error) {
	username, password, ok := r.BasicAuth()
	if !ok {
		return "", "", errors.ErrInvalidClient
	}
	return username, MyEncrypter(password), nil
}

// ....
server.SetClientInfoHandler(MyClientBasicHandler)

Good luck

from oauth2.

dzhu avatar dzhu commented on August 13, 2024

That doesn't cover everything, unfortunately. For example, bcrypt, which is a good and common choice for hashing passwords, is generally implemented so it doesn't produce a deterministic output; it generates a random salt as part of the algorithm. So you can't reproduce the same hash given the same password (short of trying many times, of course), but have to instead check a password by passing it and the original hash directly to a comparison function.

from oauth2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.