Comments (3)
It's great to see your interest in adding the Unwrap method to the custom ResponseWriter. Your proposed solution and the requirements description look good. We encourage you to go ahead and create a pull request with your changes. Your contribution will be valuable to the project. Thank you for your willingness to improve the codebase!
About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
If you want to continue the conversation, start your reply with @dosu-bot.
from kratos.
Sure, I can guide you through the process of creating a pull request to add an "Unwrap" method to the custom ResponseWriter in the Kratos repository. Here are the steps:
-
Fork the Repository: First, you need to fork the Kratos repository to your own GitHub account.
-
Clone the Forked Repository: After forking, clone the repository to your local machine using the following commands:
git clone https://github.com/your-username/kratos.git cd kratos
-
Create a New Branch: It's a good practice to create a new branch for your changes. You can do this using the following command:
git checkout -b add-unwrap-method
-
Make Your Changes: Now, you can add the "Unwrap" method to the custom ResponseWriter in the
transport/http
package. Your proposed code looks correct. Just make sure to add it in the correct file and location. -
Commit Your Changes: After making your changes, you need to commit them. You can do this using the following commands:
git add . git commit -m "Add Unwrap method to custom ResponseWriter"
-
Push Your Changes: Next, you need to push your changes to your forked repository. You can do this using the following command:
git push origin add-unwrap-method
-
Create a Pull Request: Finally, you can create a pull request. Go to your forked repository on GitHub, select your branch, and click on "New pull request". Then, fill in the necessary details and submit it.
Please note that after submitting your pull request, it will be reviewed by the maintainers of the Kratos repository. They might ask you to make some changes or improvements to your code. So, be prepared for that.
I hope this helps! If you have any other questions, feel free to ask.
Sources
About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
If you want to continue the conversation, start your reply with @dosu-bot.
from kratos.
It's great to see your interest in adding the Unwrap method to the custom ResponseWriter. Your proposed solution and the requirements description look good. We encourage you to go ahead and create a pull request with your changes. Your contribution will be valuable to the project. Thank you for your willingness to improve the codebase!
About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
If you want to continue the conversation, start your reply with @dosu-bot.
from kratos.
Related Issues (20)
- [Feature] consule register need suport tags[] HOT 2
- When the App stops, the ctx in the afterStop callback is not available HOT 3
- [Question] How to return other Status Code in a successful HTTP request? HOT 7
- [Proposal] config feature roadmap HOT 22
- [Feature] replace kratos metrics with otel metrics HOT 3
- [The modification of header file information of http response does not take effect] ctx.Header().Set("Content-Type", "application/octet-stream") HOT 5
- [Question] How to return a custom response json? HOT 1
- Package version dependency issue HOT 4
- go generate ./...failed HOT 5
- [Feature]Add svrType related fields in proto to protoc-gen-go-http and http transport HOT 3
- proto file used to build the api document reported an error HOT 1
- consul watch, the server is offline and will not receive any notification HOT 6
- [Feature] Add NewClient method to gRPC Client HOT 3
- [Question] DDD的最佳实践方式?包括CQRS、Clean Architecture、六边形结构 HOT 5
- [Question]请教下kratos如何定义支持上传文件接口? HOT 2
- metrics statistics and usage issues [Question] HOT 5
- `stream` response in proto failed to generate http client HOT 2
- [Feature] Add kratos errors to buf remote plugin HOT 1
- [Question] I modified it based on examples/helloworld and found that client/main.go reported an error when executing. I am not sure if it is a BUG.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kratos.