load apollo config yml format panic about kratos HOT 6 CLOSED

🤖

Hi, @hoslo,

I'm helping the Kratos team manage their backlog and am marking this issue as stale. The problem reported by you involves a panic when loading the Apollo YAML config in a Kratos project. There has been a debate in the comments about whether this is a bug or a naming convention issue, and a suggested workaround by another user to define a separate codec for yml.

Could you please let us know if this issue is still relevant to the latest version of the Kratos repository? If it is, please comment on the issue to let the Kratos team know. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days. Thank you!

from kratos.

The two codes are exactly the same, only the package with the same name does not look very halal 😂

maybe we should put them in one package (yaml)?

from kratos.

I don't think this is a bug, yaml or yml is just a difference in declaring suffixes. If we add a separate yml encoding package for yml, I think it would be strange

from kratos.

I don't think this is a bug, yaml or yml is just a difference in declaring suffixes. If we add a separate yml encoding package for yml, I think it would be strange

how you think should to solve this question?

from kratos.

The two codes are exactly the same, only the package with the same name does not look very halal 😂

from kratos.

Yes, I ran into this problem early on and I had to define codec for yml like below, but I think kratos developers should realize that yaml and yml are the same and should provide consistent codec.

encoding.RegisterCodec(codec{})

type codec struct{}

func (codec) Marshal(v interface{}) ([]byte, error) {
	return yaml.Marshal(v)
}

func (codec) Unmarshal(data []byte, v interface{}) error {
	return yaml.Unmarshal(data, v)
}

func (codec) Name() string {
	return "yml"
}

from kratos.