Add support for TEXT column type to CreateTables() about gorp HOT 9 OPEN

Yes! +1

To add text is very necessary!

from gorp.

There needs to be more control over types. I made a suggestion in this issue here https://github.com/coopernurse/gorp/issues/58.

My biggest issue is some of my types need to be BINARY. For now I think I'm going to create tables manually.

from gorp.

👍

from gorp.

+1

from gorp.

+1

from gorp.

seems an elementary feature... issue opened a year ago... no comment from project owner... doesn't look good?

from gorp.

I fully agree with the comments above. For me, working only with Postgresql databases it is impossible to take GORM seriously without this feature.

from gorp.

The ToSqlType() command in the default dialects is primarily provided as an example. You can easily write your own dialect that implements ToSqlType() with any rules you like.

If you'd like to extend the default dialect, one option is to add an optional field to PostgresDialect that specifies the cutoff for maxsize that would dictate whether to use a text field. But this is a slippery slope that may further reinforce the idea that the provided dialect implementations are intended to satisfy all use cases.

from gorp.

I think a really easy change would be to add a new attribute to ColumnMap to override the SQL type. Since TEXT, for example, can be used just like varchar anyway, that could work out in this case.

I mean we can override the column size, so why not the column type, too?

from gorp.