Comments (20)
from gitea.
@lunny that means never having the commit-hash !
I think commit-hash should always be there except for builds on tag
from gitea.
These are my 2 cents, because we should always keep valid semver versions:
go build on branch master: 1.0.0+dev, 1.1.0+dev, 1.2.0+dev
go build on branch v1.0: 1.0.0+dev, 1.0.1+dev, 1.0.2+dev
go build on tag v1.0.0: 1.0.0+631c18a
make on branch master: 1.0.0+dev, 1.1.0+dev, 1.2.0+dev
make on branch v1.0: 1.0.0+631c18a, 1.0.1+631c18b, 1.0.2+631c18c
make on tag v1.0.0: 1.0.0+631c18a
These are also valid versions for most packages like rpm or deb.
Edit: Maybe we should even stick with make on branch master: 1.0.0+dev, 1.1.0+dev, 1.2.0+dev
, otherwise we can not differentiate it anymore.
Edit: And maybe go build on tag v1.0.0: 1.0.0+631c18a
won't work because we can not patch the commit into the tag code, so more like go build on tag v1.0.0: 1.0.0+dev
;)
from gitea.
go build on tag v1.0.0: 1.0.0+631c18a
make on tag v1.0.0: 1.0.0+631c18a
I think only 1.0.0
is ok for tags.
from gitea.
In our project we use git describe --tag
and build with
$ go build -ldflags "-w -s -X main.Version=${VERSION}"
from gitea.
It seems it's a good idea
from gitea.
So we should create a make.bash & make.bat instead a Makefile? @tboerger
from gitea.
We can accomplish that with the Makefile as well, I would just add the version part to it.
from gitea.
Makefile ask people to install make system first. Many gophers come from Ruby and Python not C or C++. And since build Gitea is so easy that it's no need a Makefile. Or we can move it to 1.1.0?
from gitea.
from gitea.
Go get should simply have 0.0.0+master
from gitea.
But most gophers also got build-essentials installed which also includes make
from gitea.
On Mon, Nov 07, 2016 at 06:31:56AM -0800, Thomas Boerger wrote:
Go get should simply have 0.0.0+master
How about 1.0.0-dev, and incremented after release ?
from gitea.
Because we should always provide valid version numbers.
from gitea.
is 1.0.0-dev
invalid ?
from gitea.
Yes
from gitea.
from gitea.
go build on branch master: 1.0+dev
go build on branch v1.0: 1.0.0+dev
go build on tag v1.0.0: 1.0.0
make on branch master: 1.0+hash
make on branch v1.0: 1.0.0+hash
make on tag v1.0.0: 1.0.0
from gitea.
On Mon, Nov 07, 2016 at 07:26:56AM -0800, Thomas Boerger wrote:
These are my 2 cents, because we should always keep valid semver versions:
go build on branch master: 1.0.0+dev, 1.1.0+dev, 1.2.0+dev
go build on branch v1.0: 1.0.0+dev, 1.0.1+dev, 1.0.2+dev
go build on tag v1.0.0: 1.0.0+631c18amake on branch master: 1.0.0+631c18a, 1.1.0+631c18b, 1.2.0+631c18c
make on branch v1.0: 1.0.0+631c18a, 1.0.1+631c18b, 1.0.2+631c18c
make on tag v1.0.0: 1.0.0+631c18aThese are also valid versions for most packages like rpm or deb.
+1, it works for me.
from gitea.
@lunny that'd be even better but I'm afraid go build
cannot possibly include the hash w/out changing a version file on each and every commit. make
instead would extract it dynamically
from gitea.
Related Issues (20)
- Non-confidential OAuth 2 clients should not be issued a client secret at all
- Configuring ROOT_URL after Docker startup will be invalid HOT 5
- Release: Publish Gitea 1.22 HOT 4
- Add MDX linter for docs directory. HOT 1
- 404 in UI when publishing container image with a slash in name HOT 4
- Elasticsearch 8 support HOT 1
- meilisearch key permissions HOT 2
- debian12 cpu very hight 100% and Always restart HOT 27
- Logout doesn't work sometimes HOT 11
- Gitea siliently fails to start HOT 9
- Log Fatal might not output the message (especailly on Windows)
- PRs should ignore merge commits
- Code search + repo indexer HOT 1
- Wrong selection of event type when creating/updating a webhook via Gitea API HOT 2
- Cannot create issue attachment via the API when using query parameter HOT 4
- Javascript promise error on dashboard HOT 9
- pubring.db.lock after unclean shutdown breaks gpg related actions
- Git grep search error HOT 6
- styles are still broken on project cards HOT 5
- tcp: write: broken pipe: [E] Render failed: failed to render template + [E] plainTextInternal (status=500) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitea.