GSMacOSXCompatible default turns on some unintended things about libs-base HOT 6 CLOSED

This code supposes that the macOS compatible option is to throw an exception if a NULL selector is passed in...

NSObject.m:

- (BOOL) respondsToSelector: (SEL)aSelector
{
  Class cls = object_getClass(self);

  if (aSelector == 0)
    {
      if (GSPrivateDefaultsFlag(GSMacOSXCompatible))
	{
	  [NSException raise: NSInvalidArgumentException
		    format: @"%@ null selector given",
	    NSStringFromSelector(_cmd)];
	}
      return NO;
    }

  if (class_respondsToSelector(cls, aSelector))
    {
      return YES;
    }

  if (class_isMetaClass(cls))
    {
      return [(Class)self resolveClassMethod: aSelector];
    }
  else
    {
      return [cls resolveInstanceMethod: aSelector];
    }
}

The following test shows that this is not the case... https://github.com/gcasa/SheetTest. The call to respondsToSelector:NULL does not throw an exception on macOS. I am not sure if adding a ! in front of it is the right thing to do either, but I believe that was the intent.

from libs-base.

@rfm Do you have any thoughts?

from libs-base.

Please see my comments on the corresponding PR

from libs-base.

This simply means that OSX behavior has changed since the version that was current when the code was written.
So if OSX now behaves the same way as GNUstep, we can remove the check.

from libs-base.

Okay, I think that's reasonable. I will make that change.

from libs-base.

PR mentioned above was merged.

from libs-base.