Build is broken on Ubuntu 16.04 about libs-base HOT 8 CLOSED

Thanks. This change was not intended to be source incompatible, but I forgot that objc_slot was a publicly visible type.

from libs-base.

Note: This is a bug in the master branch of libobjc2. Using the 1.9 release branch should fix it (and is probably recommended anyway, unless you are using a patched clang and want to test the new ABI).

from libs-base.

@davidchisnall D'OH. Just as Murphy postulated, I tried all branches and all commits except 1.9 (initially I though it's the same as master just by looking at the commit dates) and got the same result but it build successfully with 1.9! Thanks.

from libs-base.

@davidchisnall For my future reference :) is it intended that master branches of libobjc2 and gnustep-base remain compatible?

Stjepan ran into this problem earlier in the week as well. I vaguely recalled some problem and so I was able to help him.

from libs-base.

I am going to close this issue here. If the problem persists, could you please open one against libobjc2 to make it clear where the clean up is needed?

from libs-base.

This is a libobjc2 bug, but it's exposed by a GNUstep bug: we should be conditionally including objc/slot.h, not including it and redeclaring functions from it.

from libs-base.

If you could specify the condition to check for, I am willing to add this. For which version of libobjc2 are the local copies of this functions needed?

from libs-base.

David, I just checked the history of this code and it was added by you on 24 Sep 2010. Maybe it is best to leave what ever clean up is needed here also to you? Maybe the whole code branch could be deleted by now or is only needed for old versions of libobjc2?

from libs-base.