Git Product home page Git Product logo

Comments (11)

pulb avatar pulb commented on May 18, 2024

some helpful info: http://forums.mozillazine.org/viewtopic.php?f=18&t=1713815

from firefox-gnome.

garrett avatar garrett commented on May 18, 2024

I have this.

I actually even have a fix for hovered icons. The background is a nice CSS gradient that is based on the SVG from the mockup where the GTK+ them came from. I was also able to mimic the hover glow effect for the icons (using a SVG filter effect I made). For pure black icons, nothing changes, as I kept black and near black colors the same, for text legibility.

It looks nice and works with all buttons, including the close buttons too.

It's not done yet, as I still have to finish the click (:active) state.

from firefox-gnome.

pulb avatar pulb commented on May 18, 2024

push! push! push! :-D

from firefox-gnome.

garrett avatar garrett commented on May 18, 2024

It's not perfect, but I did push the changes. Sorry for everything being intermingled, but when I changed one thing, it affected another, so I had to "rebalance" a lot of different elements.

from firefox-gnome.

garrett avatar garrett commented on May 18, 2024

So the hover is fixed, and the click is mostly. The click looks a little bit wrong on the tabs on bottom mode, but looks fine in tabs on top.

from firefox-gnome.

pulb avatar pulb commented on May 18, 2024

Thanks! I like most of the changes, esp. the thin border in tabs on bottom mode looks much better. Though the background bar gradient in tabs on bottom mode could be a little more subtle.

from firefox-gnome.

garrett avatar garrett commented on May 18, 2024

Oh yeah, perhaps it should be. I adjusted both to be the same, but it might need to be different, really.

from firefox-gnome.

pulb avatar pulb commented on May 18, 2024

I'm not sure if there should be a gradient at all, other apps like gedit don't have one either.

from firefox-gnome.

Garve avatar Garve commented on May 18, 2024

Hello!

Thanks for this theme, it's awesome! Just one little bug. If you click (and hold) a button in the toolbar, you get this:
http://www.wuala.com/de/api/preview/Garve/Public/screenshot.png

from firefox-gnome.

pulb avatar pulb commented on May 18, 2024

Hi and thanks for your bug report. This is a known issue due to CSS limitations. We probably need to use images to exactly mimic the adwaita button-press-style.

from firefox-gnome.

garrett avatar garrett commented on May 18, 2024

Since we dropped the old-style toolbar support, I think we can close this bug?

from firefox-gnome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.