Git Product home page Git Product logo

Comments (7)

lmartins avatar lmartins commented on July 26, 2024 1

Oh, sorry @ohmybrew it did yes. I had to restart valet, not only nginx, not sure why, but other than that it did the trick. Thanks so much for your suggestion and all the work on this library!

from laravel-shopify.

ncpope avatar ncpope commented on July 26, 2024

It's been a while since I tested it but it looks like I had to specify a 200 http response on a proxy I did.

return response($html, 200)->header('Content-Type', 'application/liquid');

from laravel-shopify.

gnikyt avatar gnikyt commented on July 26, 2024

Hmm I'll check this out. But yes, try strictly returning 200. I'll test it out and see if something's changed with Shopify.

from laravel-shopify.

gnikyt avatar gnikyt commented on July 26, 2024

Are you using Valet? I believe the redirection loop is caused by the Nginx config. I am unable to reproduce. See image attached.

If you're using valet secure && valet share, and you're on a free plan, you need to edit your Nginx config in ~/.valet/Nginx for the site, and comment out the first server block, then run sudo brew services restart nginx to make the changes take affect. This will prevent the constant redirect (known issue with Valet + Ngok + Free account).

068aeef7e0e63bfa2f42bf6eb324220f _image 202018-06-11 20at 2012 46 06 20am

from laravel-shopify.

lmartins avatar lmartins commented on July 26, 2024

Hi @ohmybrew , thanks so much for the detailed feedback. I am indeed using the setup you describe, so I'll give this a try and confirm the fix.

Thanks so much!

from laravel-shopify.

gnikyt avatar gnikyt commented on July 26, 2024

Thanks, start valet secure and share. Once running, then edit the nginx entry, then restart nginx and should be good.

from laravel-shopify.

gnikyt avatar gnikyt commented on July 26, 2024

Hey @lmartins Did the Valet nginx trick help?

from laravel-shopify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.