Comments (15)
gnikyt
commented on September 2, 2024
Solved in v5.0.0
from basic-shopify-api.
demoskp
commented on September 2, 2024
Hi sorry to bother again, I tried it with the new code and I still don't seem to get the location header, it's not returned in the response again. Am I missing a step?
from basic-shopify-api.
gnikyt
commented on September 2, 2024
It does a complete redirect and gets the code for you, no location header will exist at the point. Its following base Guzzle config.
from basic-shopify-api.
demoskp
commented on September 2, 2024
This is supposed to get the discount code location. What code does it get for me and where is it stored?
On 26 Feb 2019 14:21, Tyler King <[email protected]> wrote:
It does a complete redirect and gets the code for you, no location header will exist at the point. Its following base Guzzle config.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#16 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AY_kvYAvgw1hyAs1vvjIosJThSHLqqz7ks5vRULSgaJpZM4bQXtD>.
from basic-shopify-api.
gnikyt
commented on September 2, 2024
No since Guzzle default redirects, and with the new fix to adjust that redirect URL, it will now properly work.
It will simply split out the discount code.
If it does not be found, you will see this: https://imgur.com/a/zwVkqX9
from basic-shopify-api.
demoskp
commented on September 2, 2024
I'll try it again today and see how it goes, thanks though.
On 26 Feb 2019 14:32, Tyler King <[email protected]> wrote:
No since Guzzle default redirects, and with the new fix to adjust that redirect URL, it will now properly work.
https://imgur.com/a/dIQ6tOw
It will simply split out the discount code.
If it does not be found, you will see this: https://imgur.com/a/zwVkqX9
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#16 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AY_kvchYrsKHxssGC02S88SYm8qCDkJnks5vRUV4gaJpZM4bQXtD>.
from basic-shopify-api.
demoskp
commented on September 2, 2024
When it doesn't find the code it returns exactly what you said which is "+"errors": "Not Found""
However when I try to get an existing code accessing the body return null.
I am not sure what the issue is in my case, I updated the BasicShopifyAPI.php file so I am not sure if there is something I am missing here.
from basic-shopify-api.
gnikyt
commented on September 2, 2024
What's the request you're sending out, what do you mean a code that exists? I try with a code that exists, and returns fine On Feb. 26, 2019 18:06, demoskp <[email protected]> wrote:When it doesn't find the code it returns exactly what you said which is "+"errors": "Not Found""
However when I try to get an existing code accessing the body return null.
I am not sure what the issue is in my case, I updated the BasicShopifyAPI.php file so I am not sure if there is something I am missing here.
—You are receiving this because you modified the open/close state.Reply to this email directly, view it on GitHub, or mute the thread.
from basic-shopify-api.
demoskp
commented on September 2, 2024
$shop->api()->request('GET' , '/admin/discount_codes/lookup.json?code=example')->body;
What I mean is if a discount code actually exists on the store and I do the lookup it return null on the body. If that discount code does not exist on that store then I get the errors": "Not Found"" as the body which is great.
The issue is when it should return the the discount code, the price rule and then rest like your example but in my case it doesn't.
from basic-shopify-api.
gnikyt
commented on September 2, 2024
Try doing:$shop->api()->request('GET' , '/admin/discount_codes/lookup.json', ['code' => 'example'])->body;On Feb. 26, 2019 18:38, demoskp <[email protected]> wrote:$shop->api()->request('GET' , '/admin/discount_codes/lookup.json?code=example')->body;
What I mean is if a discount code actually exists on the store and I do the lookup it return null on the body. If that discount code does not exist on that store then I get the errors": "Not Found"" as the body which is great.
The issue is when it should return the the discount code, the price rule and then rest like your example but in my case it doesn't.
—You are receiving this because you modified the open/close state.Reply to this email directly, view it on GitHub, or mute the thread.
from basic-shopify-api.
demoskp
commented on September 2, 2024
Tried that as well, it still returns null for the body.
from basic-shopify-api.
gnikyt
commented on September 2, 2024
Found the issue! Requires some rework... reopening.
from basic-shopify-api.
gnikyt
commented on September 2, 2024
v5.1.0 should have this all fixed up now.
from basic-shopify-api.
demoskp
commented on September 2, 2024
Works like a charm, thanks a lot mate.
On 27 Feb 2019 20:16, Tyler King <[email protected]> wrote:
v5.1.0 should have this all fixed up now.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#16 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AY_kvbpV6swuxGbHCKi0xur_NjCfnC-5ks5vRuekgaJpZM4bQXtD>.
from basic-shopify-api.
gnikyt
commented on September 2, 2024
Good to hear!
from basic-shopify-api.
Related Issues (20)
- REST API Rate Limit Issues - handleRest() function - AWS Lambda HOT 4
- RateLimiter blowing up after change HOT 6
- Inconsistent Error Handling in use of Body in Response HOT 1
- Unable to set header on graphQL for Retrieving Storefront API translations HOT 1
- It would be useful to be able to change the graphql endpoint URL
- Custom Store Implementations HOT 1
- Problem with GraphQL and multiple mutations HOT 1
- getSession
- PHP 8.1 Warnings HOT 1
- Object of type Osiset\BasicShopifyAPI\BasicShopifyAPI is not callable
- cURL Timeout HOT 1
- v10.0.6 throws errors in PHP 7.4 HOT 2
- Return value of Osiset\BasicShopifyAPI\ResponseAccess::offsetGet() must be an instance of Osiset\BasicShopifyAPI\mixed, string returned HOT 3
- Resource Route not working HOT 1
- Sessions don't have a session ID HOT 1
- How to update webhook URL's for old stores? HOT 1
- Rest api upload image HOT 1
- Call to undefined function env() HOT 6
- Query is not working
- not finding classes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from basic-shopify-api.