Error in checksum calculation in flash.cpp about grbl-lpc HOT 3 OPEN

I also suspect it should be |, but I made use the same formula as memcpy_to_eeprom_with_checksum and memcpy_from_eeprom_with_checksum in https://github.com/gnea/grbl/blob/5c8dcefcbdc72e953fb07c5f8bb8ef4925ac6b5b/grbl/eeprom.c

@chamnit ?

from grbl-lpc.

That piece of code has a bug and hasnt worked since 2010-2011 when it was first installed by the original author of Grbl. I discovered it a couple years ago but decided to leave it alone. If I fix it, everyone would get their EEPROM wiped automatically since their checksums would all be wrong. This problem is being fixed in the next major version with a better Fletcher checksum.

@tbfleming It’s up to you if you want to fix it. Like I said before, it’ll wipe everyone’s settings unless you write and test some countermeasures.

from grbl-lpc.

I'll leave it be for now. I'll keep this issue open.

from grbl-lpc.