Git Product home page Git Product logo

Comments (8)

vchrisb avatar vchrisb commented on July 17, 2024 1

thx @gmag11 !
IMHO you should not release a new version before your pull request is accepted.
Looking at the history of the time repo it does not look like it will be merged soon.

from ntpclient.

gmag11 avatar gmag11 commented on July 17, 2024 1

I'm thinking about rolling back the use of std::function on TimeLib. There are quite a few open pull requests on its repository. So most probably my pull will not be included on original lib
I will stitch to original TimeLib features so you don't need to use my fork.

from ntpclient.

vchrisb avatar vchrisb commented on July 17, 2024

I have the same issue.

from ntpclient.

gmag11 avatar gmag11 commented on July 17, 2024

Ah ok, I made a change on TimeLib library to accept std::function. I've proposed a pull to his author but it has not been accepted yet. You need to use my TimeLib fork if you want to run versions after 17th august. Sorry for the annoyance.

from ntpclient.

reaper7 avatar reaper7 commented on July 17, 2024

@gmag11 - tnx for info, with Your fork of TimeLib everything works OK 👍

from ntpclient.

gmag11 avatar gmag11 commented on July 17, 2024

Meanwhile you can use my TimeLib fork or stay with commit before modification. My roll back will not affect library interface, so it will be transparent for your code.

from ntpclient.

gmag11 avatar gmag11 commented on July 17, 2024

Last commit should work with original TimeLib.h. Please test it.

from ntpclient.

reaper7 avatar reaper7 commented on July 17, 2024

Yes, it's true, tested 👍

from ntpclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.