Git Product home page Git Product logo

Comments (3)

RudyFiero avatar RudyFiero commented on July 17, 2024

I just briefly looked at this. While it is nice to have a call for each item I would be concerned about rollover issues. Like the seconds changing from 59 to 0 and then the minute increments. (a bigger concern with higher rollovers) And if the rollover happens between your calls then you end up with the incorrect time. I think it would be better to do one call that populates a structure and then you get to pick out what you need from it. Only one now. Not multiple.

from ntpclient.

Azuzula avatar Azuzula commented on July 17, 2024

Aha, good point. I thought its save all data in variable "moment" filled in one NTP call and then I can pick what I need before next call happen.
I understand now, it is better one call and then parse data from string what I get.

from ntpclient.

gmag11 avatar gmag11 commented on July 17, 2024

I think there is a little misunderstanding of what this library does.

It does not keep or count time, so its intention is not to get time or date from your sketch. That task is performed by Time library by Paul Stroffregen. That's where now() and other functions you need are coded.

NTPClientLib connects a NTP server two times a day, for instance, to keep time in sync. I coded some functions to get string encoded date for my convenience, but it is not library's core.

You don't need to force NTP sync to get time, time keeping and time synchronization are independent tasks done in different libraries.

I'll keep this issue open for the moment if you like to add some comments.

from ntpclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.