Git Product home page Git Product logo

Comments (5)

peow avatar peow commented on July 17, 2024

Wouldn't it help if this feature was disabled by default?
perhaps having a warning when the person tries to enable it, saying that this feature may contain bugs and that errors should not be reported to Trinkets but to AdditionZ?

from additionz.

Globox1997 avatar Globox1997 commented on July 17, 2024

Seems like there is indeed a bug with the slot positions (tested only with less than 9 trinket slots), was so sure it would work xD.

However as @peow suggested, I would rather turn this feature off by default (cause all features in this mod are toggleable).
Fixed the position bug and turned off the feature by default with cb3a044.

Imo such a small feature does not deserve its own mod and it is basically the idea for the Addition mod to collect just small features (yes other mods of mine are small feature mods but I try to decrease them).
Not sure how you take on PRs so I just added it to this mod. Thanks for the info tho.

I hope that is okay for you and your discord does not get more users asking for help or just report this bug.
If not, let me know. Publised the changes with v1.3.1

from additionz.

Globox1997 avatar Globox1997 commented on July 17, 2024

Any thoughts @emilyploszaj ?

from additionz.

emilyploszaj avatar emilyploszaj commented on July 17, 2024

It is preferable to have this off by default and that eases some of the problem but I still believe something this drastic should be part of trinkets or in a mod that is clearly for this purpose.

from additionz.

Globox1997 avatar Globox1997 commented on July 17, 2024

Okay, than I'll keep it off by default, thx for the reply.

from additionz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.