Git Product home page Git Product logo

Comments (5)

progrium avatar progrium commented on May 27, 2024

Yes, that's how it should be. Thank you.

On Mon, Dec 15, 2014 at 5:05 AM, Žilvinas Kybartas <[email protected]

wrote:

I have issue that one container starting right after registrator container
is skipped, sometimes. Looking at the code I see that theoretically its
possible that it would happen in between when fetching and registering
existing containers and adding listeners for new ones.
Maybe it would help if event listener would be registered right before
fetching existing containers?


Reply to this email directly or view it on GitHub
https://github.com/progrium/registrator/issues/73.

Jeff Lindsay
http://progrium.com

from registrator.

derekelkins avatar derekelkins commented on May 27, 2024

As a general thought, it may be beneficial to periodically (15-60s) ask docker what the current state is and update based on that. This allows events to be missed either by Registrator or by systems downstream of Registrator without them becoming permanent issues. This would mitigate this issue and issue #94 and arguably resolve issue #81. I may put together a pull request for this depending on how involved it looks. I may make a separate (enhancement) issue for this.

In my case I'm pretty sure the issue is Consul isn't ready to route to itself when Registrator starts providing events, so they get sent nowhere.

from registrator.

progrium avatar progrium commented on May 27, 2024

Yes, I think this ideal but will take some refactoring. But just as a first
step, I would take any PR that adds periodic syncing that basically do the
same thing as the initial sync (which may need to be refactored to work
alongside streaming updates).

On Sat, Jan 31, 2015 at 10:34 PM, Derek Elkins [email protected]
wrote:

As a general thought, it may be beneficial to periodically (15-60s) ask
docker what the current state is and update based on that. This allows
events to be missed either by Registrator or by systems downstream of
Registrator without them becoming permanent issues. This would mitigate
this issue and issue #94
https://github.com/progrium/registrator/issues/94 and arguably resolve
issue #81 https://github.com/progrium/registrator/issues/81. I may put
together a pull request for this depending on how involved it looks. I may
make a separate (enhancement) issue for this.

In my case I'm pretty sure the issue is Consul isn't ready to route to
itself when Registrator starts providing events, so they get sent nowhere.


Reply to this email directly or view it on GitHub
https://github.com/progrium/registrator/issues/73#issuecomment-72353856.

Jeff Lindsay
http://progrium.com

from registrator.

mgood avatar mgood commented on May 27, 2024

Looks like the recently merged PR #109 should have addressed this.

from registrator.

progrium avatar progrium commented on May 27, 2024

Oh, yes that's right.

from registrator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.