[doc] hint for a less verbose http-check for consul-haproxy users about registrator HOT 6 CLOSED

Maybe it's better that check-http in docker-consul is silent by default when healthy. Do you want to submit that as an issue against docker-consul?

from registrator.

Sure, I will move that to docker-consul were it belong indeed. I will test a few thing and open a PR and an issue there.

Thinking about it, I feel it would be best to remove the timestamp on both success and failure condition. Otherwise, a lasting failed check will also cause consul-haproxy to also reload itself each 5 minutes.

from registrator.

Right ... what's producing the timestamp?

from registrator.

It's from the http header 'Date' being display by curl in docker-consul:check-http

[default command used]
curl --silent --show-error --fail --dump-header /dev/stderr --retry 2 $opts http://www.google.com > /dev/null

HTTP/1.1 302 Found
Cache-Control: private
Content-Type: text/html; charset=UTF-8
Location: http://www.google.ca/?gfe_rd=cr&ei=En5sVLnlNsSD8Qfft4GgBg <---------
Content-Length: 258
Date: Wed, 19 Nov 2014 11:25:06 GMT <----------
Server: GFE/2.0
Alternate-Protocol: 80:quic,p=0.01

The 'Location' header could also be problematic if it change on each check. Possibly others.

What about a default check-http without --dump-header ? It will be clean and we still have some reporting in case of 4xx/5xx error. This will not trigger constant consul sync as the output won't change at each check, be it a fail or success.

from registrator.

Yeah I guess you can always add --dump-header if you want it.

On Wed, Nov 19, 2014 at 5:49 AM, pfcarrier [email protected] wrote:

It's from the http header 'Date' being display by curl in
docker-consul:check-http

[default command used]
curl --silent --show-error --fail --dump-header /dev/stderr --retry 2
$opts http://www.google.com > /dev/null

HTTP/1.1 302 Found
Cache-Control: private
Content-Type: text/html; charset=UTF-8
Location: http://www.google.ca/?gfe_rd=cr&ei=En5sVLnlNsSD8Qfft4GgBg
<---------
Content-Length: 258
Date: Wed, 19 Nov 2014 11:25:06 GMT <----------
Server: GFE/2.0
Alternate-Protocol: 80:quic,p=0.01

The 'Location' header could also be problematic if it change on each
check. Possibly others.

What about a default check-http without --dump-header ? It will be clean
and we still have some reporting in case of 4xx/5xx error. This will not
trigger constant consul sync as the output won't change at each check, be
it a fail or success.

—
Reply to this email directly or view it on GitHub
https://github.com/progrium/registrator/issues/20#issuecomment-63628721.

Jeff Lindsay
http://progrium.com

from registrator.

Dropping support for check-http since Consul has native HTTP checks supported by Registrator now.

from registrator.