Git Product home page Git Product logo

Comments (6)

bjgrosse avatar bjgrosse commented on May 14, 2024

Another vote for this!

from glide-data-grid.

jassmith avatar jassmith commented on May 14, 2024

Yes this can be added, we cant get rid of the wrapper entirely but we can unstyle it.

from glide-data-grid.

pzcfg avatar pzcfg commented on May 14, 2024

That works for me!

One other issue I've been running into is needing more editor space below the cell. Currently there's a max-height: calc(100vh - ${p => p.targetRect.y + 10}px) that's preventing that from growing. I can use the experimental.paddingBottom to help alleviate this if the user manually scrolls down, but if they haven't, it only scrolls to the bottom of the cell itself and then keeps it clipped. Do you have a suggestion for working around that?

from glide-data-grid.

jassmith avatar jassmith commented on May 14, 2024

What do you want that to do? Currently it stops the cell editor going off screen

from glide-data-grid.

pzcfg avatar pzcfg commented on May 14, 2024

I think in the ideal world, if the child wants to grow, it would scroll the table so that the top of the editor still lines up with the cell but the bottom of the editor isn't cut off, but that seems overly complicated. Maybe the editor could specify an anticipated max-height and the table will try to scroll that extra amount when you go to edit?

For now I think I can work around it using paddingBottom and scrollTo with paddingY getting added here #139 (comment)

I'll give some more thought on what would be best here

from glide-data-grid.

jassmith avatar jassmith commented on May 14, 2024

Fixed in 3.3.0

from glide-data-grid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.