The field that displays IP address of the server and players can be removed. <p di

I updated my code. <a class="issue-link js-issue-link" data-error-text="Failed to load

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

IP addresses don't need to be shown on the web about glest-masterserver HOT 8 CLOSED

glest commented on June 8, 2024

IP addresses don't need to be shown on the web

from glest-masterserver.

pushkar-anand commented on June 8, 2024

I would like to take up this issue.

from glest-masterserver.

andy5995 commented on June 8, 2024

ok, it's still open.

from glest-masterserver.

andy5995 commented on June 8, 2024

Oh, I just realized... could you also remove the Game protocol port column as part of your PR?

from glest-masterserver.

pushkar-anand commented on June 8, 2024

Yes sure.

from glest-masterserver.

yannik995 commented on June 8, 2024

This change should be made in the PHP code, as the IP address can otherwise be seen in the HTML source code.

from glest-masterserver.

pushkar-anand commented on June 8, 2024

Okay, I will remove it completely.

from glest-masterserver.

pushkar-anand commented on June 8, 2024

I updated my code. #12

from glest-masterserver.

andy5995 commented on June 8, 2024

@yannik995 we typically try to merge PRs from people who first offered on the ticket. This helps save people time and prevent duplicate pull requests. It's explained more in our CONTRIBUTING document. https://github.com/ZetaGlest/zetaglest-source/blob/develop/CONTRIBUTING.md#issues

I appreciate your help with this though. I plan to be opening more tickets on this repo very soon, so you may want to keep an eye on things.

from glest-masterserver.

Recommend Projects