Git Product home page Git Product logo

Comments (4)

mchaver avatar mchaver commented on May 30, 2024

I just realized that int is int32 in BuckleScript.

from bs-json.

glennsl avatar glennsl commented on May 30, 2024

It is, but that really only applies to some integer operations, not to the value itself. In this case it's due to how it checks if the value is an integer. It's actually unintentional and can be fixed, though I'm not sure it should be. But let me reopen and think about it for a bit...

from bs-json.

mchaver avatar mchaver commented on May 30, 2024

float seems to be able to handle a lot longer values. Maybe it should check if it is a int64?

from bs-json.

glennsl avatar glennsl commented on May 30, 2024

They're all just JavaScript numbers at run time, it's just a matter of how they're interpreted. I've fixed the rejection in Json.Decode.int, but in the process discovered that OCaml will overflow int literals larger than Int32.max_int without warning, which is a bit scary. At least it's a known issue that will eventually be fixed: rescript-lang/rescript-compiler#373

from bs-json.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.