Clicking delete or disown cause navigation to split file about splits-io HOT 4 CLOSED

Seems like it's an issue with linkify-table-rows.coffee. Might just need to change the selector to something along the lines of tr[href] :not(a) to prevent navigation when clicking on links.

from splits-io.

Yeah, I'm actually leaning towards removing that JavaScript and replacing it with something simpler. It's trying to simulate links, which is pretty bad behavior because it's doing it poorly. We don't get to see the link destination our browser tells us when we mouseover, we don't get the ability to middle click, right clicks don't recognize that we're right clicking a link (because we're technically not), etc.

The alternatives are to

1. replace that table with a series of as with display: block or something so that it still looks like a table but it's actually not, which would let us link rows trivially;
2. remove the whole "the whole row is a hyperlink" thing and just use a flat table with normal links on the run's title; or
3. continue the current behavior but on a per-cell basis instead of per-row, and exclude the last cell on every row from being linkified.

I either want 1 or 2 but I'm not sure which yet.

from splits-io.

Option 2 sounds like it would work fine - it wouldn't be too much more of a learning curve (as the title of the run is still a link), and it's pretty uniform with how most tables of links work. Would be simple as hell to implement, as well.

Obviously up to you in the end, though.

from splits-io.

Yeah option 2 is nice and simple, both in code and UI. Maybe eventually I will change my mind, but for now this is good.

from splits-io.