Comments (4)
Seems like it's an issue with linkify-table-rows.coffee. Might just need to change the selector to something along the lines of tr[href] :not(a)
to prevent navigation when clicking on links.
from splits-io.
Yeah, I'm actually leaning towards removing that JavaScript and replacing it with something simpler. It's trying to simulate links, which is pretty bad behavior because it's doing it poorly. We don't get to see the link destination our browser tells us when we mouseover, we don't get the ability to middle click, right clicks don't recognize that we're right clicking a link (because we're technically not), etc.
The alternatives are to
- replace that
table
with a series ofa
s withdisplay: block
or something so that it still looks like a table but it's actually not, which would let us link rows trivially; - remove the whole "the whole row is a hyperlink" thing and just use a flat table with normal links on the run's title; or
- continue the current behavior but on a per-cell basis instead of per-row, and exclude the last cell on every row from being linkified.
I either want 1 or 2 but I'm not sure which yet.
from splits-io.
Option 2 sounds like it would work fine - it wouldn't be too much more of a learning curve (as the title of the run is still a link), and it's pretty uniform with how most tables of links work. Would be simple as hell to implement, as well.
Obviously up to you in the end, though.
from splits-io.
Yeah option 2 is nice and simple, both in code and UI. Maybe eventually I will change my mind, but for now this is good.
from splits-io.
Related Issues (20)
- Speedrun.com game variables don't show in the auto-submit dialogue
- Game renamed on speedrun.com
- YouTube doesn't allow chapters < 10s
- Build a "did you really mean to do that?" feature for adopting histories accidentally
- Video seeking should always use realtime
- Handle default timing better
- PBing in gametime but not in realtime makes Splits.io "prefer" the wrong PB
- Emails can be obviously not emails
- Double negatives
- Use "an" over "a" where appropriate
- Inherit timing setting from previous upload
- SpeedRunsLive races panel slow/unresponsive
- Clicking on combined splits doesn't correctly seek video
- Redirect-on-login doesn't work
- Emails are case sensitive
- Megaman support
- Splits for Mega Man 2 don't have twitch "Auto-highlight"? HOT 3
- Ability to use subsplit sections for Youtube chapters
- Segment group durations artificially short when a split is skipped
- Show avatar in settings avatar area
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from splits-io.