Git Product home page Git Product logo

Comments (3)

gkjohnson avatar gkjohnson commented on May 17, 2024 1

With the merged pickle_rick model I'm seeing that the extremes are

{
  "depth":{"min":9,"max":32},
  "tris":{"min":1,"max":4570}
}

I'm thinking maybe 35 or 40 or so being the default? I think adding the warning log is a good idea

from three-mesh-bvh.

gkjohnson avatar gkjohnson commented on May 17, 2024

The bounds trees generated in our tests and benchmarks are at depths of 19 and 22 respectively for a bit more context. I'm wondering if setting this to a safer / lower value should be the responsibility of the application generating the BVH rather than built in as the default?

from three-mesh-bvh.

mqp avatar mqp commented on May 17, 2024

I would definitely make the default some maximum -- what it should be, I'm not sure.

If you're concerned about people accidentally hitting the maximum without realizing it's a relevant tunable, it might be worth making a console warning come out if the maximum is reached.

from three-mesh-bvh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.