Git Product home page Git Product logo

Comments (4)

mqp avatar mqp commented on May 17, 2024

It's possible that removing fields conditionally (and thereby making all the nodes not have homogeneous shapes) could hurt performance due to JIT inline caching, so it's worth benchmarking after this to make sure there's not a regression.

from three-mesh-bvh.

gkjohnson avatar gkjohnson commented on May 17, 2024

That's a good point. If it does wind up being slower then having two different classes may be a better option? One with children and one with tris?

I'll also have to see how much removing a key really saves here. I'm not so familiar with how to estimate memory use when it comes to javascript object keys.

from three-mesh-bvh.

mqp avatar mqp commented on May 17, 2024

No idea if the objects having the same prototype will make a difference or not.

Removing children is particularly appealing since for leaf nodes it's an empty array, so we're paying memory twice -- once for the pointer and once for the empty array. tris is just null for non-leaves so we only pay for the pointer.

from three-mesh-bvh.

gkjohnson avatar gkjohnson commented on May 17, 2024

Most unneeded fields removed in #44

from three-mesh-bvh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.