Git Product home page Git Product logo

Comments (3)

givanz avatar givanz commented on May 23, 2024

Hi

This happens because browser security does not allow iframe mouse events to bubble up.

The easiest solution to avoid ugly hacks is to wrap the iframe and use the wrapper to select and control the element using the child property.

<div data-component-iframe>
	<iframe src="https://www.vvveb.com" width="320" height="240"></iframe>
</div>
Vvveb.Components.extend("_base", "html/iframe", {
    attributes: ["data-component-iframe"],
    name: "Iframe",
    image: "icons/file.svg",
    html: '<div data-component-iframe><iframe src="https://www.vvveb.com" width="320" height="240"></iframe></div>',
	properties: [{
        name: "Src",
        key: "src",
        htmlAttr: "src",
        child:"iframe",
        inputtype: TextInput
    }, {
        name: "Width",
        key: "width",
        htmlAttr: "width",
        child:"iframe",
        inputtype: TextInput
    }, {
        name: "Height",
        key: "height",
        htmlAttr: "height",
        child:"iframe",
        inputtype: TextInput
	}]	
});

I added a new iframe component using this approach in the last commit 56aea4f.

from vvvebjs.

Aremu-damilare avatar Aremu-damilare commented on May 23, 2024

Hi

This happens because browser security does not allow iframe mouse events to bubble up.

The easiest solution to avoid ugly hacks is to wrap the iframe and use the wrapper to select and control the element using the child property.

<div data-component-iframe>
	<iframe src="https://www.vvveb.com" width="320" height="240"></iframe>
</div>
Vvveb.Components.extend("_base", "html/iframe", {
    attributes: ["data-component-iframe"],
    name: "Iframe",
    image: "icons/file.svg",
    html: '<div data-component-iframe><iframe src="https://www.vvveb.com" width="320" height="240"></iframe></div>',
	properties: [{
        name: "Src",
        key: "src",
        htmlAttr: "src",
        child:"iframe",
        inputtype: TextInput
    }, {
        name: "Width",
        key: "width",
        htmlAttr: "width",
        child:"iframe",
        inputtype: TextInput
    }, {
        name: "Height",
        key: "height",
        htmlAttr: "height",
        child:"iframe",
        inputtype: TextInput
	}]	
});

I added a new iframe component using this approach in the last commit 56aea4f.

Thanks, I already did that.

I added nodes: ["iframe",] without this <div data-component-iframe></div> and NumberInput. I have also been studying the logics.

I am a web developer, I wish to add a countdown timer to vvvweb as a way of showing appreciation, I will take my time.

What do you think?

from vvvebjs.

givanz avatar givanz commented on May 23, 2024

I am a web developer, I wish to add a countdown timer to vvvweb as a way of showing appreciation, I will take my time.

Sure, contributions are welcome.

Regarding the counter the only issue I see is the js dependency, currently the components don't have js dependency management, where is the case this is done manually like here https://github.com/givanz/VvvebJs/blob/master/libs/builder/components-widgets.js#L679-L690

from vvvebjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.