Comments (17)
Lets just take the first 6 characters of the SHA?
And fail the build if we still go over 20?
On Tue, Dec 10, 2013 at 6:20 AM, danielmarbach [email protected]:
I got the followin scenario:
{
"Major":0,
"Minor":6,
"Patch":0,
"Stability":"Unstable",
"Suffix":"3c588406",
"LongVersion":"0.6.0-unstable.feature-945905e1 Branch:'GitFlowVersion2'
Sha:'9
45905e1e25eb85a001c99174a1df4f0aa854723'","NugetVersion":"0.6.0-Feature-GitFlowVersion2-945905e1e25eb85a001c99174a1df4f0
aa854723",
"ShortVersion":"0.6.0-unstable.feature-945905e1",
"BranchName":"GitFlowVersion2",
"BranchType":"Feature",
"Sha":"945905e1e25eb85a001c99174a1df4f0aa854723"
}It seems that the nuget version is bound to max 20 chars.
09.12.2013 23:52:30: [Info] Building the nuget spec file at
C:\Projects\machine.specifications.dani\Misc\machine.specifications.nuspec
as version
0.6.0-Feature-GitFlowVersion2-945905e1e25eb85a001c99174a1df4f0aa854723
09.12.2013 23:52:31: [Error] Error creating package: The special version
part cannot exceed 20 characters.
09.12.2013 23:52:31: [Error] ripple.RippleFatalError: Error creating
package: The special version part cannot exceed 20 characters.
09.12.2013 23:52:31: [Error] Error executing CreatePackages
09.12.2013 23:52:31: [Error] ripple.RippleFatalError: Error creating
package: The special version part cannot exceed 20 characters.
at ripple.RippleAssert.Fail(String message, Object[] substitutions)
at ripple.Model.PublishingService.createPackage(PackageBuilder builder,
String outputPath)
at ripple.Model.PublishingService.CreatePackage(PackageParams ctx)
at ripple.Steps.CreatePackages.<>c__DisplayClass1.b__0(NugetSpec spec)
at System.Collections.Generic.GenericEnumerableExtensions.EachT
at ripple.RippleOperation.Execute(Boolean throwOnFailure)
09.12.2013 23:53:00: [Info] Building the nuget spec file at
C:\Projects\machine.specifications.dani\Misc\machine.specifications.nuspec
as version 0.6.0-unstable.feature-945905e1
09.12.2013 23:53:00: [Error] Error executing CreatePackages
09.12.2013 23:53:00: [Error] System.ArgumentException:
'0.6.0-unstable.feature-945905e1' is not a valid version string.
Parameter name: version
at NuGet.SemanticVersion.Parse(String version)
at ripple.Steps.CreatePackages.<>c__DisplayClass1.b__0(NugetSpec spec)
at System.Collections.Generic.GenericEnumerableExtensions.EachT
at ripple.RippleOperation.Execute(Boolean throwOnFailure)
10.12.2013 00:00:26: [Info] Building the nuget spec file at
C:\Projects\machine.specifications.dani\Misc\machine.specifications.nuspec
as version
10.12.2013 00:00:26: [Error] Error executing CreatePackages
10.12.2013 00:00:26: [Error] System.ArgumentException: Value cannot be
null or an empty string.
Parameter name: version
at NuGet.SemanticVersion.Parse(String version)
at ripple.Steps.CreatePackages.<>c__DisplayClass1.b__0(NugetSpec spec)
at System.Collections.Generic.GenericEnumerableExtensions.EachT
at ripple.Steps.CreatePackages.execute(CreatePackagesInput input,
IRippleStepRunner runner)
at ripple.Steps.RippleStep1.Execute(RippleInput input, IRippleStepRunner
runner)
at ripple.RippleOperation.Execute(Boolean throwOnFailure)
10.12.2013 00:00:56: [Info] Building the nuget spec file at
C:\Projects\machine.specifications.dani\Misc\machine.specifications.nuspec
as version 0.6.0-unstable.feature-945905e1
10.12.2013 00:00:56: [Error] Error executing CreatePackages
10.12.2013 00:00:56: [Error] System.ArgumentException:
'0.6.0-unstable.feature-945905e1' is not a valid version string.
Parameter name: version
at NuGet.SemanticVersion.Parse(String version)
at ripple.Steps.CreatePackages.<>c__DisplayClass1.b__0(NugetSpec
spec)
at
System.Collections.Generic.GenericEnumerableExtensions.Each[T](IEnumerable1
values, Action1 eachAction)
at ripple.Steps.CreatePackages.execute(CreatePackagesInput input,
IRippleStepRunner runner)
at ripple.Steps.RippleStep1.Execute(RippleInput input, IRippleStepRunner
runner)
at ripple.RippleOperation.Execute(Boolean throwOnFailure)I tagged develop and branch from it to a feature branch.
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/54
.
from gitversion.
@andreasohlund that doesnt give us much to work with
The special version part cannot exceed 20 characters.
so given @danielmarbach s example the version would be 0.6.0-Feature-GitFlowVers
@danielmarbach do you have any ideas on a convention?
from gitversion.
How about {version}-{NameOfBranch.First(6)}-{SHA.First(6)}?
On Tue, Dec 10, 2013 at 9:08 AM, Simon Cropp [email protected]:
@andreasohlund https://github.com/andreasohlund that doesnt give us
much to work withThe special version part cannot exceed 20 characters.
so given @danielmarbach https://github.com/danielmarbach s example the
version would be 0.6.0-Feature-GitFlowVers@danielmarbach https://github.com/danielmarbach do you have any ideas
on a convention?—
Reply to this email directly or view it on GitHubhttps://github.com//issues/54#issuecomment-30206318
.
from gitversion.
As long as it works with ripple. Fine!
from gitversion.
If we follow proper SemVer as define here:
Wouldn't we need?:
Version-stability+AnythingElse
Therefore
0.6.0-{alpha¦feature¦....First(6)}+{sha.First(6)}
from gitversion.
I'm referring especially to the following chapters:
A pre-release version MAY be denoted by appending a hyphen and a series of dot
separated identifiers immediately following the patch version. Identifiers MUST
comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]. Identifiers MUST NOT
be empty. Numeric identifiers MUST NOT include leading zeroes. Pre-release
versions have a lower precedence than the associated normal version. A
pre-release version indicates that the version is unstable and might not satisfy
the intended compatibility requirements as denoted by its associated normal
version. Examples: 1.0.0-alpha, 1.0.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92.
Build metadata MAY be denoted by appending a plus sign and a series of dot
separated identifiers immediately following the patch or pre-release version.
Identifiers MUST comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-].
Identifiers MUST NOT be empty. Build metadata SHOULD be ignored when determining
version precedence. Thus two versions that differ only in the build metadata,
have the same precedence. Examples: 1.0.0-alpha+001, 1.0.0+20130313144700,
1.0.0-beta+exp.sha.5114f85.
Andreas Öhlund [email protected] hat am 10. Dezember 2013 um 09:18
geschrieben:How about {version}-{NameOfBranch.First(6)}-{SHA.First(6)}?
On Tue, Dec 10, 2013 at 9:08 AM, Simon Cropp [email protected]:
@andreasohlund https://github.com/andreasohlund that doesnt give us
much to work withThe special version part cannot exceed 20 characters.
so given @danielmarbach https://github.com/danielmarbach s example the
version would be 0.6.0-Feature-GitFlowVers@danielmarbach https://github.com/danielmarbach do you have any ideas
on a convention?—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/54#issuecomment-30206318
.
Reply to this email directly or view it on GitHub:
#54 (comment)
from gitversion.
Any news on how to progress here?
From: Andreas Öhlund [mailto:[email protected]]
Sent: Dienstag, 10. Dezember 2013 09:18
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple on feature branch can fail (#54)
How about {version}-{NameOfBranch.First(6)}-{SHA.First(6)}?
On Tue, Dec 10, 2013 at 9:08 AM, Simon Cropp < mailto:[email protected] [email protected]>wrote:
@andreasohlund < https://github.com/andreasohlund https://github.com/andreasohlund> that doesnt give us
much to work withThe special version part cannot exceed 20 characters.
so given @danielmarbach < https://github.com/danielmarbach https://github.com/danielmarbach> s example the
version would be 0.6.0-Feature-GitFlowVers@danielmarbach < https://github.com/danielmarbach https://github.com/danielmarbach> do you have any ideas
on a convention?—
Reply to this email directly or view it on GitHub< #54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
.
—
Reply to this email directly or view it on GitHub #54 (comment) . https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif
from gitversion.
Slightly OT but we actually don't build feature branches (since it will
cause double builds if you have PR building on in TC). Instead we promote
the use of PR's. Ie if you want to get the build going just open up a [WIP]
Pull
http://blog.half-ogre.com/posts/software/rules-of-the-open-road/
That said, since you rarely use the binaries of a featurebranch perhaps we
should just make it unique?
{develop.major}.{develop.minor}.{develop.patch}-Feature{SHA.First(6)} ?
On Wed, Dec 11, 2013 at 8:23 PM, danielmarbach [email protected]:
Any news on how to progress here?
From: Andreas Öhlund [mailto:[email protected]]
Sent: Dienstag, 10. Dezember 2013 09:18
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple on feature
branch can fail (#54)How about {version}-{NameOfBranch.First(6)}-{SHA.First(6)}?
On Tue, Dec 10, 2013 at 9:08 AM, Simon Cropp < <mailto:
[email protected]> [email protected]>wrote:@andreasohlund < https://github.com/andreasohlund
https://github.com/andreasohlund> that doesnt give us
much to work withThe special version part cannot exceed 20 characters.
so given @danielmarbach < https://github.com/danielmarbach
https://github.com/danielmarbach> s example the
version would be 0.6.0-Feature-GitFlowVers@danielmarbach < https://github.com/danielmarbach
https://github.com/danielmarbach> do you have any ideas
on a convention?—
Reply to this email directly or view it on GitHub< <
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
.
—
Reply to this email directly or view it on GitHub <
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206782>
. <
https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif>—
Reply to this email directly or view it on GitHubhttps://github.com//issues/54#issuecomment-30353678
.
from gitversion.
Fine for me. Did you read the semver specs?
Am 11.12.2013 um 20:54 schrieb Andreas Öhlund [email protected]:
Slightly OT but we actually don't build feature branches (since it will
cause double builds if you have PR building on in TC). Instead we promote
the use of PR's. Ie if you want to get the build going just open up a [WIP]
Pullhttp://blog.half-ogre.com/posts/software/rules-of-the-open-road/
That said, since you rarely use the binaries of a featurebranch perhaps we
should just make it unique?{develop.major}.{develop.minor}.{develop.patch}-Feature{SHA.First(6)} ?
On Wed, Dec 11, 2013 at 8:23 PM, danielmarbach [email protected]:
Any news on how to progress here?
From: Andreas Öhlund [mailto:[email protected]]
Sent: Dienstag, 10. Dezember 2013 09:18
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple on feature
branch can fail (#54)How about {version}-{NameOfBranch.First(6)}-{SHA.First(6)}?
On Tue, Dec 10, 2013 at 9:08 AM, Simon Cropp < <mailto:
[email protected]> [email protected]>wrote:@andreasohlund < https://github.com/andreasohlund
https://github.com/andreasohlund> that doesnt give us
much to work withThe special version part cannot exceed 20 characters.
so given @danielmarbach < https://github.com/danielmarbach
https://github.com/danielmarbach> s example the
version would be 0.6.0-Feature-GitFlowVers@danielmarbach < https://github.com/danielmarbach
https://github.com/danielmarbach> do you have any ideas
on a convention?—
Reply to this email directly or view it on GitHub< <
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
.
—
Reply to this email directly or view it on GitHub <
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206782>
. <
https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif>—
Reply to this email directly or view it on GitHubhttps://github.com//issues/54#issuecomment-30353678
.—
Reply to this email directly or view it on GitHub.
from gitversion.
I have read them, what part are you referring to?
Since this is a nuget constraint another option would be to keep it as is
and just set the "nugetversion" to version.ToString().Take(20) ?
On Wed, Dec 11, 2013 at 9:16 PM, danielmarbach [email protected]:
Fine for me. Did you read the semver specs?
Am 11.12.2013 um 20:54 schrieb Andreas Öhlund [email protected]:
Slightly OT but we actually don't build feature branches (since it will
cause double builds if you have PR building on in TC). Instead we
promote
the use of PR's. Ie if you want to get the build going just open up a
[WIP]
Pullhttp://blog.half-ogre.com/posts/software/rules-of-the-open-road/
That said, since you rarely use the binaries of a featurebranch perhaps
we
should just make it unique?{develop.major}.{develop.minor}.{develop.patch}-Feature{SHA.First(6)} ?
On Wed, Dec 11, 2013 at 8:23 PM, danielmarbach [email protected]:
Any news on how to progress here?
From: Andreas Öhlund [mailto:[email protected]]
Sent: Dienstag, 10. Dezember 2013 09:18
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple on
feature
branch can fail (#54)How about {version}-{NameOfBranch.First(6)}-{SHA.First(6)}?
On Tue, Dec 10, 2013 at 9:08 AM, Simon Cropp < <mailto:
[email protected]> [email protected]>wrote:@andreasohlund < https://github.com/andreasohlund
https://github.com/andreasohlund> that doesnt give us
much to work withThe special version part cannot exceed 20 characters.
so given @danielmarbach < https://github.com/danielmarbach
https://github.com/danielmarbach> s example the
version would be 0.6.0-Feature-GitFlowVers@danielmarbach < https://github.com/danielmarbach
https://github.com/danielmarbach> do you have any ideas
on a convention?—
Reply to this email directly or view it on GitHub< <https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
.
—
Reply to this email directly or view it on GitHub <https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206782>
. <
—
Reply to this email directly or view it on GitHub<
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30353678>.
—
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/54#issuecomment-30359180
.
from gitversion.
I think the nuget version GFV provides is wrong. According to the specs it should be {major}.{minor}.{patch}-{stability}+{additional}
Am 12.12.2013 um 08:09 schrieb Andreas Öhlund [email protected]:
I have read them, what part are you referring to?
Since this is a nuget constraint another option would be to keep it as is
and just set the "nugetversion" to version.ToString().Take(20) ?On Wed, Dec 11, 2013 at 9:16 PM, danielmarbach [email protected]:
Fine for me. Did you read the semver specs?
Am 11.12.2013 um 20:54 schrieb Andreas Öhlund [email protected]:
Slightly OT but we actually don't build feature branches (since it will
cause double builds if you have PR building on in TC). Instead we
promote
the use of PR's. Ie if you want to get the build going just open up a
[WIP]
Pullhttp://blog.half-ogre.com/posts/software/rules-of-the-open-road/
That said, since you rarely use the binaries of a featurebranch perhaps
we
should just make it unique?{develop.major}.{develop.minor}.{develop.patch}-Feature{SHA.First(6)} ?
On Wed, Dec 11, 2013 at 8:23 PM, danielmarbach [email protected]:
Any news on how to progress here?
From: Andreas Öhlund [mailto:[email protected]]
Sent: Dienstag, 10. Dezember 2013 09:18
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple on
feature
branch can fail (#54)How about {version}-{NameOfBranch.First(6)}-{SHA.First(6)}?
On Tue, Dec 10, 2013 at 9:08 AM, Simon Cropp < <mailto:
[email protected]> [email protected]>wrote:@andreasohlund < https://github.com/andreasohlund
https://github.com/andreasohlund> that doesnt give us
much to work withThe special version part cannot exceed 20 characters.
so given @danielmarbach < https://github.com/danielmarbach
https://github.com/danielmarbach> s example the
version would be 0.6.0-Feature-GitFlowVers@danielmarbach < https://github.com/danielmarbach
https://github.com/danielmarbach> do you have any ideas
on a convention?—
Reply to this email directly or view it on GitHub< <https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
.
—
Reply to this email directly or view it on GitHub <https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206782>
. <
—
Reply to this email directly or view it on GitHub<
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30353678>.
—
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/54#issuecomment-30359180
.—
Reply to this email directly or view it on GitHub.
from gitversion.
So you're saying that it should be eg:
0.6.0-Feature+8A50C5
Assuming Stability=Feature
Ifaik nuget would blow up if you include a + sign in the nuget version?
(@SimonCropp)
On Thu, Dec 12, 2013 at 11:12 AM, danielmarbach [email protected]:
I think the nuget version GFV provides is wrong. According to the specs it
should be {major}.{minor}.{patch}-{stability}+{additional}Am 12.12.2013 um 08:09 schrieb Andreas Öhlund [email protected]:
I have read them, what part are you referring to?
Since this is a nuget constraint another option would be to keep it as
is
and just set the "nugetversion" to version.ToString().Take(20) ?On Wed, Dec 11, 2013 at 9:16 PM, danielmarbach [email protected]:
Fine for me. Did you read the semver specs?
Am 11.12.2013 um 20:54 schrieb Andreas Öhlund <
[email protected]>:Slightly OT but we actually don't build feature branches (since it
will
cause double builds if you have PR building on in TC). Instead we
promote
the use of PR's. Ie if you want to get the build going just open up
a
[WIP]
Pullhttp://blog.half-ogre.com/posts/software/rules-of-the-open-road/
That said, since you rarely use the binaries of a featurebranch
perhaps
we
should just make it unique?{develop.major}.{develop.minor}.{develop.patch}-Feature{SHA.First(6)} ?
On Wed, Dec 11, 2013 at 8:23 PM, danielmarbach <
[email protected]>wrote:Any news on how to progress here?
From: Andreas Öhlund [mailto:[email protected]]
Sent: Dienstag, 10. Dezember 2013 09:18
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple on
feature
branch can fail (#54)How about {version}-{NameOfBranch.First(6)}-{SHA.First(6)}?
On Tue, Dec 10, 2013 at 9:08 AM, Simon Cropp < <mailto:
[email protected]> [email protected]>wrote:@andreasohlund < https://github.com/andreasohlund
https://github.com/andreasohlund> that doesnt give us
much to work withThe special version part cannot exceed 20 characters.
so given @danielmarbach < https://github.com/danielmarbach
https://github.com/danielmarbach> s example the
version would be 0.6.0-Feature-GitFlowVers@danielmarbach < https://github.com/danielmarbach
https://github.com/danielmarbach> do you have any ideas
on a convention?—
Reply to this email directly or view it on GitHub< <https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
.
—
Reply to this email directly or view it on GitHub <https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206782>
. <
—
Reply to this email directly or view it on GitHub<
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30353678>
.
—
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHub<
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30359180>.
—
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/54#issuecomment-30403777
.
from gitversion.
Just reread the nuget spec. You’re right they don’t support full semver specs.
Additional:
version.ToString().Take(20)
Would it be better to take Last(6) of the SHA to get every changing identifier per commit?
From: Andreas Öhlund [mailto:[email protected]]
Sent: Donnerstag, 12. Dezember 2013 12:24
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple on feature branch can fail (#54)
So you're saying that it should be eg:
0.6.0-Feature+8A50C5
Assuming Stability=Feature
Ifaik nuget would blow up if you include a + sign in the nuget version?
(@SimonCropp)
On Thu, Dec 12, 2013 at 11:12 AM, danielmarbach < mailto:[email protected] [email protected]>wrote:
I think the nuget version GFV provides is wrong. According to the specs it
should be {major}.{minor}.{patch}-{stability}+{additional}Am 12.12.2013 um 08:09 schrieb Andreas Öhlund < mailto:[email protected] [email protected]>:
I have read them, what part are you referring to?
Since this is a nuget constraint another option would be to keep it as
is
and just set the "nugetversion" to version.ToString().Take(20) ?On Wed, Dec 11, 2013 at 9:16 PM, danielmarbach < mailto:[email protected] [email protected]>wrote:
Fine for me. Did you read the semver specs?
Am 11.12.2013 um 20:54 schrieb Andreas Öhlund <
mailto:[email protected] [email protected]>:Slightly OT but we actually don't build feature branches (since it
will
cause double builds if you have PR building on in TC). Instead we
promote
the use of PR's. Ie if you want to get the build going just open up
a
[WIP]
Pullhttp://blog.half-ogre.com/posts/software/rules-of-the-open-road/ http://blog.half-ogre.com/posts/software/rules-of-the-open-road/
That said, since you rarely use the binaries of a featurebranch
perhaps
we
should just make it unique?{develop.major}.{develop.minor}.{develop.patch}-Feature{SHA.First(6)} ?
On Wed, Dec 11, 2013 at 8:23 PM, danielmarbach <
mailto:[email protected]%3ewrote [email protected]>wrote:Any news on how to progress here?
From: Andreas Öhlund [mailto:[email protected]]
Sent: Dienstag, 10. Dezember 2013 09:18
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple on
feature
branch can fail (#54)How about {version}-{NameOfBranch.First(6)}-{SHA.First(6)}?
On Tue, Dec 10, 2013 at 9:08 AM, Simon Cropp < <mailto:
mailto:[email protected] [email protected]> mailto:[email protected]%3ewrote [email protected]>wrote:@andreasohlund < < https://github.com/andreasohlund https://github.com/andreasohlund>
https://github.com/andreasohlund https://github.com/andreasohlund> that doesnt give us
much to work withThe special version part cannot exceed 20 characters.
so given @danielmarbach < < https://github.com/danielmarbach https://github.com/danielmarbach>
https://github.com/danielmarbach https://github.com/danielmarbach> s example the
version would be 0.6.0-Feature-GitFlowVers@danielmarbach < < https://github.com/danielmarbach https://github.com/danielmarbach>
https://github.com/danielmarbach https://github.com/danielmarbach> do you have any ideas
on a convention?—
Reply to this email directly or view it on GitHub< <#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
.
—
Reply to this email directly or view it on GitHub <#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206782>
. <
https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif>
—
Reply to this email directly or view it on GitHub<
#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30353678>
.
—
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHub<
#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30359180>.
—
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHub< #54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30403777>
.
—
Reply to this email directly or view it on GitHub #54 (comment) . https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif
from gitversion.
Would it be better to take Last(6) of the SHA to get every changing
identifier per commit?
I thought that first 6 was always unique? (enough)
On Thu, Dec 12, 2013 at 12:49 PM, danielmarbach [email protected]:
Just reread the nuget spec. You’re right they don’t support full semver
specs.Additional:
version.ToString().Take(20)
Would it be better to take Last(6) of the SHA to get every changing
identifier per commit?From: Andreas Öhlund [mailto:[email protected]]
Sent: Donnerstag, 12. Dezember 2013 12:24
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple on feature
branch can fail (#54)So you're saying that it should be eg:
0.6.0-Feature+8A50C5
Assuming Stability=Feature
Ifaik nuget would blow up if you include a + sign in the nuget version?
(@SimonCropp)On Thu, Dec 12, 2013 at 11:12 AM, danielmarbach < <mailto:
[email protected]> [email protected]>wrote:I think the nuget version GFV provides is wrong. According to the specs
it
should be {major}.{minor}.{patch}-{stability}+{additional}Am 12.12.2013 um 08:09 schrieb Andreas Öhlund < <mailto:
[email protected]> [email protected]>:I have read them, what part are you referring to?
Since this is a nuget constraint another option would be to keep it as
is
and just set the "nugetversion" to version.ToString().Take(20) ?On Wed, Dec 11, 2013 at 9:16 PM, danielmarbach < <mailto:
[email protected]> [email protected]>wrote:Fine for me. Did you read the semver specs?
Am 11.12.2013 um 20:54 schrieb Andreas Öhlund <
mailto:[email protected] [email protected]>:Slightly OT but we actually don't build feature branches (since it
will
cause double builds if you have PR building on in TC). Instead we
promote
the use of PR's. Ie if you want to get the build going just open
up
a
[WIP]
Pullhttp://blog.half-ogre.com/posts/software/rules-of-the-open-road/
http://blog.half-ogre.com/posts/software/rules-of-the-open-road/That said, since you rarely use the binaries of a featurebranch
perhaps
we
should just make it unique?{develop.major}.{develop.minor}.{develop.patch}-Feature{SHA.First(6)} ?
On Wed, Dec 11, 2013 at 8:23 PM, danielmarbach <
mailto:[email protected]%3ewrote [email protected]>wrote:Any news on how to progress here?
From: Andreas Öhlund [mailto:[email protected]]
Sent: Dienstag, 10. Dezember 2013 09:18
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple
on
feature
branch can fail (#54)How about {version}-{NameOfBranch.First(6)}-{SHA.First(6)}?
On Tue, Dec 10, 2013 at 9:08 AM, Simon Cropp < <mailto:
mailto:[email protected] [email protected]>
mailto:[email protected]%3ewrote [email protected]>wrote:@andreasohlund < < https://github.com/andreasohlund
https://github.com/andreasohlund>
https://github.com/andreasohlund
https://github.com/andreasohlund> that doesnt give us
much to work withThe special version part cannot exceed 20 characters.
so given @danielmarbach < < https://github.com/danielmarbach
https://github.com/danielmarbach>
https://github.com/danielmarbach
https://github.com/danielmarbach> s example the
version would be 0.6.0-Feature-GitFlowVers@danielmarbach < < https://github.com/danielmarbach
https://github.com/danielmarbach>
https://github.com/danielmarbach
https://github.com/danielmarbach> do you have any ideas
on a convention?—
Reply to this email directly or view it on GitHub< <<
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
<
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
.
—
Reply to this email directly or view it on GitHub <<
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206782>https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206782>
. <
—
Reply to this email directly or view it on GitHub<
<
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30353678>https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30353678>
.
—
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHub<
<
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30359180>https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30359180>
.
—
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHub< <
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30403777>https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30403777>
.
—
Reply to this email directly or view it on GitHub <
https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30408722>
. <
https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif>—
Reply to this email directly or view it on GitHubhttps://github.com//issues/54#issuecomment-30412089
.
from gitversion.
I do not know. Didn’t read the specs. If it is the case then just do what you proposed:
version.ToString().Take(20)
From: Andreas Öhlund [mailto:[email protected]]
Sent: Donnerstag, 12. Dezember 2013 12:54
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple on feature branch can fail (#54)
Would it be better to take Last(6) of the SHA to get every changing
identifier per commit?
I thought that first 6 was always unique? (enough)
On Thu, Dec 12, 2013 at 12:49 PM, danielmarbach < mailto:[email protected] [email protected]>wrote:
Just reread the nuget spec. You’re right they don’t support full semver
specs.Additional:
version.ToString().Take(20)
Would it be better to take Last(6) of the SHA to get every changing
identifier per commit?From: Andreas Öhlund [mailto:[email protected]]
Sent: Donnerstag, 12. Dezember 2013 12:24
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple on feature
branch can fail (#54)So you're saying that it should be eg:
0.6.0-Feature+8A50C5
Assuming Stability=Feature
Ifaik nuget would blow up if you include a + sign in the nuget version?
(@SimonCropp)On Thu, Dec 12, 2013 at 11:12 AM, danielmarbach < <mailto:
mailto:[email protected] [email protected]> mailto:[email protected]%3ewrote [email protected]>wrote:I think the nuget version GFV provides is wrong. According to the specs
it
should be {major}.{minor}.{patch}-{stability}+{additional}Am 12.12.2013 um 08:09 schrieb Andreas Öhlund < <mailto:
mailto:[email protected] [email protected]> mailto:[email protected] [email protected]>:I have read them, what part are you referring to?
Since this is a nuget constraint another option would be to keep it as
is
and just set the "nugetversion" to version.ToString().Take(20) ?On Wed, Dec 11, 2013 at 9:16 PM, danielmarbach < <mailto:
mailto:[email protected] [email protected]> mailto:[email protected]%3ewrote [email protected]>wrote:Fine for me. Did you read the semver specs?
Am 11.12.2013 um 20:54 schrieb Andreas Öhlund <
< mailto:[email protected] mailto:[email protected]> mailto:[email protected] [email protected]>:Slightly OT but we actually don't build feature branches (since it
will
cause double builds if you have PR building on in TC). Instead we
promote
the use of PR's. Ie if you want to get the build going just open
up
a
[WIP]
Pull< http://blog.half-ogre.com/posts/software/rules-of-the-open-road/ http://blog.half-ogre.com/posts/software/rules-of-the-open-road/>
http://blog.half-ogre.com/posts/software/rules-of-the-open-road/ http://blog.half-ogre.com/posts/software/rules-of-the-open-road/That said, since you rarely use the binaries of a featurebranch
perhaps
we
should just make it unique?{develop.major}.{develop.minor}.{develop.patch}-Feature{SHA.First(6)} ?
On Wed, Dec 11, 2013 at 8:23 PM, danielmarbach <
< mailto:[email protected]%3ewrote mailto:[email protected]%3ewrote> mailto:[email protected]%3ewrote [email protected]>wrote:Any news on how to progress here?
From: Andreas Öhlund [mailto:[email protected]]
Sent: Dienstag, 10. Dezember 2013 09:18
To: Particular/GitFlowVersion
Cc: danielmarbach
Subject: Re: [GitFlowVersion] GitFlowVersion paired with ripple
on
feature
branch can fail (#54)How about {version}-{NameOfBranch.First(6)}-{SHA.First(6)}?
On Tue, Dec 10, 2013 at 9:08 AM, Simon Cropp < <mailto:
< mailto:[email protected] mailto:[email protected]> mailto:[email protected] [email protected]>
< mailto:[email protected]%3ewrote mailto:[email protected]%3ewrote> mailto:[email protected]%3ewrote [email protected]>wrote:@andreasohlund < < < https://github.com/andreasohlund https://github.com/andreasohlund>
https://github.com/andreasohlund https://github.com/andreasohlund>
< https://github.com/andreasohlund https://github.com/andreasohlund>
https://github.com/andreasohlund https://github.com/andreasohlund> that doesnt give us
much to work withThe special version part cannot exceed 20 characters.
so given @danielmarbach < < < https://github.com/danielmarbach https://github.com/danielmarbach>
https://github.com/danielmarbach https://github.com/danielmarbach>
< https://github.com/danielmarbach https://github.com/danielmarbach>
https://github.com/danielmarbach https://github.com/danielmarbach> s example the
version would be 0.6.0-Feature-GitFlowVers@danielmarbach < < < https://github.com/danielmarbach https://github.com/danielmarbach>
https://github.com/danielmarbach https://github.com/danielmarbach>
< https://github.com/danielmarbach https://github.com/danielmarbach>
https://github.com/danielmarbach https://github.com/danielmarbach> do you have any ideas
on a convention?—
Reply to this email directly or view it on GitHub< <<
#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
<
#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206318>
.
—
Reply to this email directly or view it on GitHub <<
#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206782>#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30206782>
. <
<
https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif>https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif>
—
Reply to this email directly or view it on GitHub<
<
#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30353678>#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30353678>
.
—
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHub<
<
#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30359180>#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30359180>
.
—
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHub< <
#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30403777>#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30403777>
.
—
Reply to this email directly or view it on GitHub <
#54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30408722>
. <
https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif>—
Reply to this email directly or view it on GitHub< #54 (comment) https://github.com/Particular/GitFlowVersion/issues/54#issuecomment-30412089>
.
—
Reply to this email directly or view it on GitHub #54 (comment) . https://github.com/notifications/beacon/TUqL6p7Xz6SF-_dIEJ1YBBsteGGyfPXeZ48zmQW4KohheorAIc8R6dav3SYweed4.gif
from gitversion.
FWIW, I'm a TeamCity old-hat as well. I created a build step between the build and pack phases. The step executed the following posh script:
$rx = "^(\d\.\d.\d)-([^-]+)-(.+)/(.+)-(\w{40})$"
$tc_bn = "%build.number%"
$gf_v = "%GitFlowVersion.Version%"
$gf_nv = "%GitFlowVersion.NugetVersion%"
$m = $tc_bn -match $rx
if ($m)
{
$tc_bn = "$($matches[1])-$($matches[2])-$($matches[5])".Substring(0,20)
echo "##teamcity[buildNumber '$tc_bn']"
}
$m = $gf_v -match $rx
if ($m)
{
$gf_v = "$($matches[1])-$($matches[2])-$($matches[5])".Substring(0,20)
echo "##teamcity[setParameter name='GitFlowVersion.Version' value='$gf_v']"
}
$m = $gf_nv -match $rx
if ($m)
{
$gf_nv = "$($matches[1])-$($matches[2])-$($matches[5])".Substring(0,20)
echo "##teamcity[setParameter name='GitFlowVersion.NugetVersion' value='$gf_nv']"
}
After that Nuget is happy. It just sucks Nuget has this limitation though. I read the comment thread above and elected to use the branch type (feature, hotfix, etc.) instead of the branch "name" (if you consider the true name to not have the type prefix). However, I like that my Maven feature builds produce artifacts with the branch "name" in the version. Oh well.
from gitversion.
Feature branches and pull requests will always sort lower than develop now because we use
{major}.{minor}.{patch}.{numberCommitsInFrontOfMaster}-unstable so I think ripple will always use that, making this issue done?
I think I should add a feature branch example to the wiki, will open an issue for that and close this issue.
from gitversion.
Related Issues (20)
- [ISSUE]: Cannot pack on 6.0.0 HOT 5
- [ISSUE]: Errors with NugetVersionV2 variable and FullSemVer HOT 3
- [ISSUE]: continuous-delivery-fallback-label Property Not Found
- [ISSUE]: "gitversion /version" fails if not run from a git repository HOT 2
- [ISSUE]: Error when upgrading from 5.x to 6 HOT 1
- [ISSUE]: Command 'gitversion /version' has finished with exit code HOT 1
- [ISSUE]: dotnet publish: '0.0.1-abc_def.1+1' is not a valid version string HOT 4
- [ISSUE]: Mainline in 6.0.0 with default configuration values throws HOT 2
- [ISSUE]: gitversion.msbuild v6.0.1 breaks build HOT 7
- [ISSUE]: Normalizing git directory fails with LibGit2Sharp.CheckoutConflictException HOT 6
- [FEATURE]: Support of '=semver: none|minor|major|patch' bump message to suppress the version increment HOT 2
- [ISSUE]: Cannot git fetch --unshallow with AzureDevOps HOT 7
- [ISSUE]: GitVersion.MsBuild - GitVersion.MsBuild.targets and GitVersion.MsBuild.props: Error MSB3073 (gitversion.dll not found) in Version 6.0.1 HOT 2
- When workflow is set to empty string, gitversion gives errors for values not provided in config HOT 13
- [ISSUE]: Sha is appended to AssemblyInformationalVersionAttribute when gitversion.json modified before CoreGenerateAssemblyInfo MSBuild task HOT 1
- [ISSUE]: There's no NuGetVersionV2 anymore, and no zero-padded PreReleaseNumber HOT 5
- [ISSUE]: branch regex is matched against {EscapedBranchName} not {BranchName} HOT 1
- [ISSUE]: The version returned is NULL HOT 1
- Support C# format strings in config
- [ISSUE]: dotnet build fails after GitVersion.MsBuild nuget package added to C# project HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitversion.