Installation into projects using nCrunch about gitversion HOT 8 CLOSED

Pull request?;)

Den tisdagen den 1:e oktober 2013 skrev Jake Ginnivan:

Add AND $(nCrunch) =='' to the condition of importing the targets file

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11
.

http://andreasohlund.net
http://twitter.com/andreasohlund

from gitversion.

Will do, just recording it for now :)

Sent from my Windows Phone

From: Andreas Öhlundmailto:[email protected]
Sent: ‎01/‎10/‎2013 18:10
To: Particular/GitFlowVersionmailto:[email protected]
Cc: Jake Ginnivanmailto:[email protected]
Subject: Re: [GitFlowVersion] Installation into projects using nCrunch (#11)

Pull request?;)

Den tisdagen den 1:e oktober 2013 skrev Jake Ginnivan:

Add AND $(nCrunch) =='' to the condition of importing the targets file

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11
.

http://andreasohlund.net
http://twitter.com/andreasohlund

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11#issuecomment-25469464.

from gitversion.

Where is the install.ps1? I cannot find it

from gitversion.

@JakeGinnivan there is no install.ps1. the nuget build directory convention is used to import the targets https://github.com/Particular/GitFlowVersion/blob/master/GitFlowVersionTask/GitFlowVersionTask.csproj#L109

But isnt the problem with NCrunch two-fold

• not all files required by the task are being copied https://github.com/Particular/GitFlowVersion/blob/master/GitFlowVersionTask/NugetAssets/GitFlowVersionTask.targets#L31
• need to respect NCrunch when resolving SolutionDir similar to this https://github.com/Particular/GitFlowVersion/blob/master/GitFlowVersionTask/Fody.targets#L4

from gitversion.

@JakeGinnivan any update on this?

from gitversion.

Not yet, not a high priority right now. More focused on trying to make core changes to allow support for GitHubFlow soon :)

from gitversion.

Going to close this, I don't need this fixed as Im using the exe version. If someone else wants it we can reopen

from gitversion.

Currently, GitVersion fails to find the .git directory during standard NCrunch builds:

WARNING - WARN [03/19/16 9:36:36:33] Could not determine assembly version:
System.NullReferenceException: Object reference not set to an instance of an object.
   at GitVersion.GitPreparer.GetDotGitDirectory()
   at GitVersion.ExecuteCore.ExecuteGitVersion(String targetUrl, String dynamicRepositoryLocation, Authentication authentication, String targetBranch, Boolean noFetch, String workingDirectory, String commitId)
   at GitVersion.ExecuteCore.TryGetVersion(String directory, VersionVariables& versionVariables, Boolean noFetch, Authentication authentication)

This is plausible because by default, NCrunch shadow copies the projects (without .git of course).

Certainly not a show stopper as you can just disable GitVersion UpdateAssemblyInfo and GetVersion when $(NCrunch) == 1

from gitversion.