Comments (10)
@housseindjirdeh I can take a peek at this this afternoon!
from git-point.
@lex111 On almost every screen a dark status bar should be used because a light one would be impossible to see. However, on profiles, orgs and repos, a light one should be used.
from git-point.
@andrewda mmm, yeah, thanks, I did not understand at first. But however, a simple property change seems to work.
from git-point.
I noticed that when the Tab Bar is initiated it loads and renders all its' tab views one by one. The final result is the status bar color is the one defined in AuthProfile, as it is the last screen loaded. It seems that rendering a StatusBar component overrides any previously StatusBar rendered. You can even do things like:
<View>
<StatusBar barStyle="light-content" />
<StatusBar barStyle="light-content" />
<StatusBar barStyle="dark-content" />
</View>
which will render a view with only one status bar styled as "dark-content" (the last one). Maybe this things are obvious, but it was quite surprising to me, so I'm pointing that out.
Now, my idea of resolving the issue is to re-render the corresponding screen when you change a tab . That would render only the relevant StatusBar. Unfortunately, I have no idea how to force such re-rendering. Can you help me here?
from git-point.
Assigned @jouderianjr as he's working on it, using setBarStyle
as mentioned by @krizzu
from git-point.
🎉
from git-point.
Nothing but love for you <3
from git-point.
@housseindjirdeh on Android, a simple change works.
barStyle={barColor === 'light' ? 'light-content' : 'dark-content'}
But I do not understand why you need a dark status bar, can by default make it light?
from git-point.
Looping @darecki to the conversation as he similarly tried to fix the issue by changing the status bars on the top screens of the stack (see #176)
from git-point.
Hey,
What about setting status bar color imperatively using setBarStyle?
You'd not need to pass props anymore, as this setting will be just in one place.
Also, exposing a option in app settings to change status bar color would be great :)
from git-point.
Related Issues (20)
- The support URL in the app store isn't very useful
- Cannot click on the bottons on iPhone X
- Can't star a repository from iOS device HOT 2
- Failed on iOS, xcode 10 HOT 5
- Make next Android release provide 64-bit versions
- please update ios app store HOT 7
- Create ticket on iOS 12.3.1 crash when submit. HOT 1
- Upgrade to styled-components@4 HOT 1
- Tool used in the main readme prototype HOT 2
- Replace deprecated React lifecycle methods
- Icons missing on iPad HOT 2
- Use Git Data API for files HOT 7
- Multitasking
- Login problem since RN 0.59
- git point crashes user UI (I think) - locks my phone
- Fix all errors on phone HOT 1
- Fix issues HOT 1
- Question
- 5t HOT 1
- Error 403 (Forbidden)!!1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-point.