Syntax highlighting about git-point HOT 8 CLOSED

Hey, just tried your app for the first time today : very nice !
The first improvement I was thinking about was Syntax Highlighting :)

I'll try to integrate CodeMirror, I'll let you know if I have some trouble or anything else.

from git-point.

Could use a webview and make use of the excellent CodeMirror library 👍

from git-point.

Thank you so much @callodacity. I've never heard of CodeMirror before and it looks promising!!

If anybody wants to take a stab at this - don't hesitate to let us know :)

from git-point.

Thank you I'm glad you liked it :)

Yes please don't hesitate to let me know how it's coming along at anytime, will always be here to help.

from git-point.

Some news: 😃

I tried today to integrate CodeMirror inside a ReactNative WebView. I think it's a bit complicated and will not be easy as we think.

After some search, I found this lib : react-native-syntax-highlighter.
As it's my first experience with ReactNative, I prefer to use this one. What do you think about it @housseindjirdeh ?

from git-point.

Cheers thanks so much @Antoine38660 - yes that looks promising! More than happy to give that a go and see how it turns out 😄

Appreciate you taking the time to look into using CodeMirror as well!

from git-point.

This is it : 😄

One last thing before I'll be able to make the PR: I have some trouble with scrolling vertically inside the code viewer, do you have some tips or advices? (I already tried to add another ScrollView).

Edit:
As you can see, horizontal scroll is ok but vertical one isn't...

Vertical scrolling works only if you do it from the extreme left part of the screen.

Update2: Finally fixed this one 😃

from git-point.

Cheers appreciate all the details and everything, I'm so glad you managed to fix it :)

from git-point.