Git Product home page Git Product logo

Comments (8)

andrewda avatar andrewda commented on July 29, 2024 2

@housseindjirdeh No developer preview header is needed for reactions in API v4, it's all implemented and standard 👍

from git-point.

housseindjirdeh avatar housseindjirdeh commented on July 29, 2024 1

If it's okay with everyone - I'll like to take this on and tackle it over Christmas break and start my first stab at using GraphQL :)

from git-point.

andrewda avatar andrewda commented on July 29, 2024 1

👏 1.5 is going to be a good one!

from git-point.

SammyIsra avatar SammyIsra commented on July 29, 2024

Since we are moving to GraphQL, this is worth taking a look at https://developer.github.com/v4/reference/mutation/addreaction/

image

Also, getting the reactions seems also somewhat intuitive with GraphQL. Altho the end result seems a bit messy, but I am sure we can work with it!

from git-point.

RolfKoenders avatar RolfKoenders commented on July 29, 2024

That looks really nice @housseindjirdeh!

from git-point.

housseindjirdeh avatar housseindjirdeh commented on July 29, 2024

Thanks @RolfKoenders :)

Nice thank you @SammyIsra - with REST things were quite messy and I really think this can be something we can integrate after we have GraphQL integrated.

from git-point.

housseindjirdeh avatar housseindjirdeh commented on July 29, 2024

That being said - looking at the documentation for API v4 I don't see a mention of reactions being in preview mode like it is in the REST docs. @SammyIsra do you know if we need a preview URL or something of that sort to access reactions with GraphQL?

from git-point.

housseindjirdeh avatar housseindjirdeh commented on July 29, 2024

OMG OMG OMG

Time to make the move to GraphQL :)

from git-point.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.