Question: Run on pull request about licensed-ci HOT 8 CLOSED

Yes, it is the later I want, PRs from forks. I want that contributions from others should be tested. I myself also work from a fork.

from licensed-ci.

I will test this as soon as a new release is out. 😃 Thank you for the quick fix!

from licensed-ci.

@johlju sorry I missed the notification you had opened this! 👀

from licensed-ci.

I think I see where this is going wrong, thanks for the bug report I'll get a fix out in the next day or two.

from licensed-ci.

I opened https://github.com/jonabc/licensed-ci/pull/49 to fix this, though I'm also curious if you should be running licensed for all action types on the pull_request event. It seems like you'd get a lot of overlap or dual runs of the action between pushes and the pull request synchronize event type.

Would it fit your workflow to use only one of push or pull_request events?

from licensed-ci.

I like to see it run for each new commit pushed to a pull request that targets the branch main, then when I merge the pull request I want it to run on the commit that was pushed (merged) to the branch main. That is why I configured both push and pull_request but I could have misunderstood the functionality? 🙂

When there is a new commit pushed to the branch main no pull request should run (I guess here is where the synchronize event triggers?), it will run when the contributor rebases the PR.

from licensed-ci.

I think push event alone could work for your scenario. The synchronize event happens when a pull request's branch is updated to track changes made to the branch. IIRC its usage is similar to the push event, though it's limited in scope to only occur for branches that have a pull request open.

The only downside to the push event in this case is that it doesn't run on forks. You wouldn't have the action run on changes from any PRs opened from forks until they were merged into the main branch and triggered a push event. If that's a common scenario for you then what you've got above would make more sense than using the push event alone.

from licensed-ci.

@johlju I've put out a new release for the action - v1.5.3 - which can be referenced as either jonabc/licensed-ci@v1 or `jonabc/[email protected]

As a fun aside, in the process of making the release I noticed that a pre-commit hook which builds the distribution JS file wasn't being run in my local dev environment, meaning the JS that was running from the action hadn't included the change in https://github.com/jonabc/licensed-ci/issues/44 😞 . It's possible that the change related to this issue wasn't necessary but I don't think it'll hurt anything either.

Anyway, please reopen the issue if the bug isn't fixed in the latest release.

from licensed-ci.