Comments (8)
Yes, it is the later I want, PRs from forks. I want that contributions from others should be tested. I myself also work from a fork.
from licensed-ci.
I will test this as soon as a new release is out. 😃 Thank you for the quick fix!
from licensed-ci.
@johlju sorry I missed the notification you had opened this! 👀
from licensed-ci.
I think I see where this is going wrong, thanks for the bug report I'll get a fix out in the next day or two.
from licensed-ci.
I opened https://github.com/jonabc/licensed-ci/pull/49 to fix this, though I'm also curious if you should be running licensed for all action types on the pull_request
event. It seems like you'd get a lot of overlap or dual runs of the action between pushes and the pull request synchronize
event type.
Would it fit your workflow to use only one of push
or pull_request
events?
from licensed-ci.
I like to see it run for each new commit pushed to a pull request that targets the branch main
, then when I merge the pull request I want it to run on the commit that was pushed (merged) to the branch main
. That is why I configured both push
and pull_request
but I could have misunderstood the functionality? 🙂
When there is a new commit pushed to the branch main
no pull request should run (I guess here is where the synchronize
event triggers?), it will run when the contributor rebases the PR.
from licensed-ci.
I think push
event alone could work for your scenario. The synchronize
event happens when a pull request's branch is updated to track changes made to the branch. IIRC its usage is similar to the push
event, though it's limited in scope to only occur for branches that have a pull request open.
The only downside to the push event in this case is that it doesn't run on forks. You wouldn't have the action run on changes from any PRs opened from forks until they were merged into the main branch and triggered a push event. If that's a common scenario for you then what you've got above would make more sense than using the push event alone.
from licensed-ci.
@johlju I've put out a new release for the action - v1.5.3 - which can be referenced as either jonabc/licensed-ci@v1
or `jonabc/[email protected]
As a fun aside, in the process of making the release I noticed that a pre-commit hook which builds the distribution JS file wasn't being run in my local dev environment, meaning the JS that was running from the action hadn't included the change in https://github.com/jonabc/licensed-ci/issues/44 😞 . It's possible that the change related to this issue wasn't necessary but I don't think it'll hurt anything either.
Anyway, please reopen the issue if the bug isn't fixed in the latest release.
from licensed-ci.
Related Issues (19)
- Error: "does not reference a branch" when running Licensed CI HOT 3
- Error running `git add` on an empty directory HOT 2
- Dealing with PRs created after licensed has created a fixup PR HOT 3
- Better handle `refs/tags/*` refs
- Update jest to fix the dependency security warnings
- Move off of actions mocks HOT 1
- How do I actually run this tool? HOT 22
- Installation Error HOT 1
- V1.5.5 broke our flow HOT 11
- Got Validation Failed error while running the pipeline (Bundler + Gemfile approach) HOT 5
- Feature request: support schedule event
- Bump to Ruby 3.1? HOT 2
- Handle rate limiting responses when querying the GitHub API
- set-output deprecation warning when running the action HOT 4
- Is it possible to have the actions done as a bot? HOT 4
- Fundamentals action items for licensed-ci - secret-scanning
- Is it possible to have the action push signed commits? HOT 2
- Publish new action version with node 20 update HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from licensed-ci.