unix socket file does not get cleaned up about gh-ost HOT 5 CLOSED

Also, only remove socket file on startup if explicitly approved via command line flag.

from gh-ost.

Re:

Also, only remove socket file on startup if explicitly approved via command line flag.

Reasoning is that we may use the socket file as a migration "mutex"; this will prevent multiple concurrent executions of gh-ost, if so desired (recall that by default socket file is named after migrated table, so there's no collision by default).

Also, it's a bad idea to remove the file if it's really being used.

from gh-ost.

Shlomi, table names may not be unique though I guess the chances of OSC type collisions on same named tables (in different databases) on the same server are quite small maybe it might be better to use some sort of hash based on the database + table name to ensure uniqueness?

I have also seen tables named with spaces and other "non-unix" type characters so using this type of name might best be avoided if possible even if technically unix allows you to use them.

Just a thought.

from gh-ost.

@sjmudd the unix socket name is already based on database_name.table_name so no uniqueness problem here.

If you have spaces etc, then it's on you: provide your own --serve-socket-file rather than let gh-ost decide on the name.

from gh-ost.

Closed by #147

from gh-ost.