Comments (6)
@cimi Publishing a new release in ~10mn.
I started reviewing your PR, but it included a lot of unnecessary (some bad) changes (like changing the README, repo URL, version), the only change required was locking katex
to 0.7.1
. So rather than leave a review with a bunch of comments I just went ahead and committed the core change :)
It's usually a considered a bad practice to bump as part of a pull request (because it's trivial for the maintainer to bump a new version once it's on the master
).
In general pull requests should be focused on solving a single well defined problem and avoid modifying extra files (makes it longer to review and harder to merge). So as a general measure, the smaller the PR the better :)
(Just some friendly advice for next time, I appreciate you taking the time to actually submit a PR :D)
from plugin-katex.
@cimi Voilà, a 1.1.4
release is out with your fix !
from plugin-katex.
I have the same problem, it worked until very recently.
info: install plugin "katex" (*) from NPM with version 1.1.3
[project path]
├── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│ └─┬ [email protected]
│ └── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│ └── [email protected]
├── [email protected]
├── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│ └─┬ [email protected]
│ └── [email protected]
└── [email protected]
Starting up the server fails because katex
can't load. If I remove katex
from the list of plugins everything works fine.
$ gitbook serve
Live reload server started on port: 35729
Press CTRL+C to quit ...
info: 14 plugins are installed
info: 11 explicitly listed
info: loading plugin "prism"... OK
info: loading plugin "callouts"... OK
info: loading plugin "mermaid-gb3"... OK
info: loading plugin "anchor-navigation-ex"... OK
info: loading plugin "toggle-chapters"... OK
info: loading plugin "katex"... ERROR
PluginError: Error with plugin "katex": Unexpected token import
I am using the latest version of everything:
$ gitbook --version
CLI version: 2.3.2
GitBook version: 3.2.2
$ node --version
v8.2.1 (also tried with v6.9.1)
$ npm --version
5.3.0
The main katex package the plugin depends on was updated two days ago. I see that the plugin's package.json
is configured so that updates are automatically picked up:
"dependencies": {
"katex": ">=0.5.1"
}
This should be locked down to the latest known stable version.
from plugin-katex.
@SamyPesse PR #18 fixes this, I've been using it locally through npm link
.
It would be great to get this merged in soon as this issue breaks all builds that use katex.
from plugin-katex.
👍 Thanks!
I was literally looking up the documentation for npm publish
as I wanted to fix the build failures by publishing my changes under a different name.
@AaronO I see that you did not merge my commit that included the package version bump. Please publish a new version of the package on npm so we can actually use it.
from plugin-katex.
I started reviewing your PR, but it included a lot of unnecessary (some bad) changes (like changing the README, repo URL, version), the only change required was locking katex to 0.7.1. So rather than leave a review with a bunch of comments I just went ahead and committed the core change :)
Those changes should not have been part of the PR - I didn't realise github automatically includes all future commits on the originating branch in the pull request. The changes in the second commit (README, name, repo etc.) were done because I was going to publish gitbook-plugin-katex-es5
so that I can unblock my build. The original PR (first commit) only had the katex version change and the version bump.
Thank you for resolving! 🎉
from plugin-katex.
Related Issues (18)
- Block formulas HOT 7
- Please update to Katex 0.6.0 HOT 1
- "plugins": ["katex"] instead of plugins: ["katex"] HOT 2
- Cannot get inline math formula in webpage HOT 2
- Cannot insert literal ""$$" HOT 2
- Warnings during pdf generation
- Cannot present $$ inside code blocks HOT 1
- Error while build with '$$\frac{a+b}2$$'
- Can upgrade katex version from 0.7.1 to 0.10.0? HOT 1
- cannot parse \overrightarrow and \overleftarrow
- How can I ues $$ instead of {%math%}{%endmath%}?
- Can not display number sets HOT 1
- Is it possible to change the math mode delimiters? HOT 4
- Does not work with GLOSSARY.md HOT 1
- `gitbook serve` crashes on error HOT 1
- Define own commands globally
- Font size is wrong because katex style is overriden by theme HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plugin-katex.