katex=0.8.1 cannot be loaded with error "unexpected token import" about plugin-katex HOT 6 CLOSED

@cimi Publishing a new release in ~10mn.

I started reviewing your PR, but it included a lot of unnecessary (some bad) changes (like changing the README, repo URL, version), the only change required was locking katex to 0.7.1. So rather than leave a review with a bunch of comments I just went ahead and committed the core change :)

It's usually a considered a bad practice to bump as part of a pull request (because it's trivial for the maintainer to bump a new version once it's on the master).

In general pull requests should be focused on solving a single well defined problem and avoid modifying extra files (makes it longer to review and harder to merge). So as a general measure, the smaller the PR the better :)

(Just some friendly advice for next time, I appreciate you taking the time to actually submit a PR :D)

from plugin-katex.

@cimi Voilà, a 1.1.4 release is out with your fix !

from plugin-katex.

I have the same problem, it worked until very recently.

info: install plugin "katex" (*) from NPM with version 1.1.3
[project path]
├── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected]
├── [email protected]
├── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └── [email protected]
└── [email protected]

Starting up the server fails because katex can't load. If I remove katex from the list of plugins everything works fine.

$ gitbook serve
Live reload server started on port: 35729
Press CTRL+C to quit ...

info: 14 plugins are installed
info: 11 explicitly listed
info: loading plugin "prism"... OK
info: loading plugin "callouts"... OK
info: loading plugin "mermaid-gb3"... OK
info: loading plugin "anchor-navigation-ex"... OK
info: loading plugin "toggle-chapters"... OK
info: loading plugin "katex"... ERROR

PluginError: Error with plugin "katex": Unexpected token import

I am using the latest version of everything:

$ gitbook --version
CLI version: 2.3.2
GitBook version: 3.2.2

$ node --version
v8.2.1 (also tried with v6.9.1)

$ npm --version
5.3.0

The main katex package the plugin depends on was updated two days ago. I see that the plugin's package.json is configured so that updates are automatically picked up:

    "dependencies": {
        "katex": ">=0.5.1"
    }

This should be locked down to the latest known stable version.

from plugin-katex.

@SamyPesse PR #18 fixes this, I've been using it locally through npm link.

It would be great to get this merged in soon as this issue breaks all builds that use katex.

from plugin-katex.

👍 Thanks!

I was literally looking up the documentation for npm publish as I wanted to fix the build failures by publishing my changes under a different name.

@AaronO I see that you did not merge my commit that included the package version bump. Please publish a new version of the package on npm so we can actually use it.

from plugin-katex.

I started reviewing your PR, but it included a lot of unnecessary (some bad) changes (like changing the README, repo URL, version), the only change required was locking katex to 0.7.1. So rather than leave a review with a bunch of comments I just went ahead and committed the core change :)

Those changes should not have been part of the PR - I didn't realise github automatically includes all future commits on the originating branch in the pull request. The changes in the second commit (README, name, repo etc.) were done because I was going to publish gitbook-plugin-katex-es5 so that I can unblock my build. The original PR (first commit) only had the katex version change and the version bump.

Thank you for resolving! 🎉

from plugin-katex.