Comments (6)
@t-b @sschuberth I hope you don't mind that I activated the issue tracker. I also added two labels: sdk
and sdk-packages
.
from git.
When installing SDK 0.4, /packages/.git/hooks/ does not contain the pre-commit hook
Actually, I didn't install the pre-commit on purpose yet, because it does not work when amending / rebasing, and there might be other cases when you don't want the hook. If at all, it should probably be an option on the last page of the installer.
from git.
I didn't install the pre-commit on purpose yet, because it does not work when amending / rebasing
I think I found out why: there is an explicit test whether the date was modified manually. And during a rebase, it looks as if it was modified manually (because it was modified in an earlier iteration of the topic branch).
Might make sense to split out the date bumping logic from the pre-commit hook so you can call it manually. Might also make sense to detect an amend/rebase and ask the user interactively (if on an interactive terminal).
from git.
@dscho Could you please check whether sschuberth/gfw-msys1-packages#36 fixes the rebase use-case?
from git.
@sschuberth Sorry for lagging so long; I see you verified the fix already!
from git.
To be precise, I did not verify my change, but just re-reviewed it before manually merging it. So it should work ok now when amending / rebasing. Still, this issue is about the pre-commit hook not being installed by default, and that's still the case. I intend to not spend any more time on this and keep it that way as the MSYS- / mgwport-based toolchain is more or less abandoned now in favor of MSYS2 and pacman.
from git.
Related Issues (20)
- [New git-credential-manager version] GCM 2.5.1 HOT 1
- Error: Scalar Reconfiguration HOT 4
- [New mintty version] 3.7.4 HOT 1
- cant install or uninstall Git, how to get unins000 files HOT 1
- `Git` commands return nothing in elevated prompt. HOT 1
- [New gpg version] gnupg-2.5.0 HOT 1
- Packaging error - duplicated GCM HOT 3
- (invalid)
- grep crash with -i HOT 7
- "git blame -L /regex/" does not work in git-bash HOT 2
- [New msys2-runtime version] 2 new items HOT 1
- Git SSH ProxyJump Fails HOT 1
- [New msys2-runtime version] 3 new items HOT 1
- [New msys2-runtime-package version] msys2-runtime: prevent different msys2 runtime versions from sharing β¦ HOT 1
- [New msys2-runtime-package version] msys2-runtime(update-patches.sh): do generate stable checksums for th⦠HOT 1
- [New msys2-runtime-package version] msys2-runtime(update-patches.sh): configure the correct remote URL HOT 1
- [New innosetup version] is-6_3_3 HOT 2
- [New git version] v2.46.0-rc0
- $ git status . Segmentation fault% (15502/20934) HOT 1
- Please include git-lfs in MinGit HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git.