pre-commit is not installed by default about git HOT 6 CLOSED

@t-b @sschuberth I hope you don't mind that I activated the issue tracker. I also added two labels: sdk and sdk-packages.

from git.

When installing SDK 0.4, /packages/.git/hooks/ does not contain the pre-commit hook

Actually, I didn't install the pre-commit on purpose yet, because it does not work when amending / rebasing, and there might be other cases when you don't want the hook. If at all, it should probably be an option on the last page of the installer.

from git.

I didn't install the pre-commit on purpose yet, because it does not work when amending / rebasing

I think I found out why: there is an explicit test whether the date was modified manually. And during a rebase, it looks as if it was modified manually (because it was modified in an earlier iteration of the topic branch).

Might make sense to split out the date bumping logic from the pre-commit hook so you can call it manually. Might also make sense to detect an amend/rebase and ask the user interactively (if on an interactive terminal).

from git.

@dscho Could you please check whether sschuberth/gfw-msys1-packages#36 fixes the rebase use-case?

from git.

@sschuberth Sorry for lagging so long; I see you verified the fix already!

from git.

To be precise, I did not verify my change, but just re-reviewed it before manually merging it. So it should work ok now when amending / rebasing. Still, this issue is about the pre-commit hook not being installed by default, and that's still the case. I intend to not spend any more time on this and keep it that way as the MSYS- / mgwport-based toolchain is more or less abandoned now in favor of MSYS2 and pacman.

from git.