Git Product home page Git Product logo

Comments (5)

nilsnolde avatar nilsnolde commented on May 25, 2024

Ouch.. yeah right. That indeed is a problem I didn't think about.. Damn it. No matter which provider is chosen the plugin is requesting Github's /markdown endpoint. Since that request (currently) is not authenticated, Github rate limits heavily to 60 requests per minute: https://developer.github.com/v3/#rate-limiting

It's alright for 99% of the articles but heavily trafficked blogs will run into problems. Or even during development, as you encountered I guess.

Let me fix that soon. And please bump if I forget about it.

from wordpress-markdown-git.

nilsnolde avatar nilsnolde commented on May 25, 2024

Ah, actually I think this is fine the way it is tbh. Github says they restrict to 60 calls per hour per IP, meaning a single computer would have to request a post more than once a minute 60 times before the hour ends in order to be rate limited.

I think it's reasonable to assume that that won't happen unless you're in heavy testing.

I'll close but anyone who thinks their users are reading like pros can implement this :)

from wordpress-markdown-git.

nilsnolde avatar nilsnolde commented on May 25, 2024

Argh, no idea what's wrong today..

Of course it's a problem.. The "user" is the server and can actually only serve 60 requests per hour which doesn't require a lot of users to achieve.

Ok, this overtakes a lot of things in the priority lane. Will fix asap.

And sorry for the spam..

from wordpress-markdown-git.

nilsnolde avatar nilsnolde commented on May 25, 2024

Auto-closed by Github and my stupidity. This is fixed now in current master @LuigiBella. You'll have to provide your Github credentials in config.json to increase the API rate limit.

from wordpress-markdown-git.

nilsnolde avatar nilsnolde commented on May 25, 2024

Also this is fixed with 1.0.2 release:
https://wordpress.org/plugins/documents-from-git/

Please re-open if this issue continues happen.

from wordpress-markdown-git.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.