Should context.GetRawData() also copy body to BodyBytesKey? about gin HOT 3 CLOSED

According to what you said, I processed the code, you can take a look at my code below:

package main

import (
	"errors"
	"net/http"
	
	"github.com/gin-gonic/gin"
	"github.com/gin-gonic/gin/binding"
)

func main() {
	g := gin.Default()

	g.Use(func(c *gin.Context) {
		body, err := c.GetRawData()
		if err != nil {
			c.Abort()
			c.JSON(http.StatusInternalServerError,errors.New("body handling exception"))
		} else {
			c.Set(gin.BodyBytesKey,body)
		}
	})

	g.POST("/hello", func(c *gin.Context) {
		type helloBody struct {
			Name string `json:"name"`
		}
		var body helloBody
		
		err := c.ShouldBindBodyWith(&body,binding.JSON)
		if err != nil {
			return 
		}
		
		c.String(200, body.Name)

	})
	g.Run(":9000")
}

Storing the Body into context negatively affects processing in highly concurrent scenarios and requires you to manually handle the Content-Type yourself.

NOTE: This method reads the body before binding. So you should use ShouldBindWith for better performance if you need to call only once.

It is recommended to use the official default BodyBytesKey, and it is also possible to store your own key in context.

// BodyBytesKey indicates a default body bytes key.
const BodyBytesKey = "_gin-gonic/gin/bodybyteskey"

from gin.

My way forward is to call c.ShouldBindBodyWith(...) in my middleware and then c.Get(gin.BodyBytesKey) to get the body. Then later in the actual handler function, I use c.ShouldBindBodyWith(...) again to actually use the body.

from gin.

Thanks. I read through the source and that is indeed how I solved the problem.

from gin.