Comments (4)
What changes did you apply in SingleFile (related to this issue)?
from singlefile.
Sorry for the delay. I made changes in src/ui/bg/ui-menus.js to turn on MENU_ID_AUTO_SAVE_TAB to true. I also made changes in src/core/bg/config.js to enable autoSaveUnload: true. I think the issue was may be rebuilding the chromium zip file, because I was making the changes in the exploded directory directly and loading the extension through puppeteer. But these changes were being picked from lib, so rebuilding solved the issue.
Now it has been working really well, which helped solve the problem of saving long and content rich pages through singlefile cli. But from time to time, autosave on page unload does not save the file.
Here are the steps:
- Auto save this tab is the default in my set up and auto save on unload is true.
- I load the extension through puppeteer, go to the page www.apple.com/apple-vision-pro, simulate scroll to the bottom, and then call goBack to basically unload the page. This normally works for most pages, but from time to time fails for apple vision pro.
- You can easily simulate this in normal set up. Open chrome, get the singlefile extension, turn autosave on unload, open a tab, and turn on auto save this tab, and load the Url. Press on back arrow, and no file is saved. Use another Url like www.apple.com or www.apple.com/watch, everything works fine.
I think for some reason the save message is not coming through for some pages, in case they are heavy in content. I tried giving it time before I go back in that tab or before I close the browser, but it just does not produce a file.
from singlefile.
Thank you for the feedback. I'm glad to hear that you were able to find the cause the problem. I tried to reproduce the bug as described in the step 3 but I cannot reproduce it. Every time I do the test with www.apple.com/apple-vision-pro, the page is downloaded as expected after pressing the back button. Do you have other extensions installed?
from singlefile.
I'm closing the issue. Feel free to comment it if you have more info though.
from singlefile.
Related Issues (20)
- Ability to save images / fonts on disk instead of base64 HOT 1
- Can't save certain site, stuck on step 2 HOT 1
- Can't save a webpage with pop up mini boxes properly HOT 1
- 'Maximum length of filename option' not working when saving to WebDAV server HOT 1
- Special characters in the password cause the configuration file export to be incomplete. HOT 3
- weibo.com's images can't be saved in version 1.22.62 HOT 1
- how to determine filename from user script? HOT 2
- Can't save specific page using the extension HOT 1
- SingleFile Downloaded Self-Extracting ZIP File Displays Blank Page When Opened HOT 1
- SingleFile error: TypeError: can't access property "length", this.options.worklets is undefined HOT 1
- Typo in Template functions help HOT 1
- Anti-theft chain image save failure HOT 6
- Option "HTML > remove unused attributes" HOT 1
- Add option to export web pages to single EPUB Format HOT 1
- Option "save print version" HOT 1
- BUG: when saving openai article SingleFile does not preserve the content of the embedded tabs HOT 1
- BUG: SingleFile error: [object Object] HOT 1
- XML cannot be rendered properly HOT 1
- Unicode-range matching bug HOT 1
- CORS policy violation errors appear in console on saved page. Results in blank page instead of saved content. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from singlefile.