Git Product home page Git Product logo

Comments (4)

giaf avatar giaf commented on June 11, 2024

Hi Lander,

thank you for your bug report.
Could you specify some more information about your build (e.g. TARGET, LA, MF), such that I can identify the issue?

I just tried out with Haswell target, high-performance LA and panel major matrix format, and the output of the permutation you propose is correctly 0 2 1.
Notice that kmax should be set to 3 in this case (i.e. 3 permutations are applied), if you set it to 2 you would get the output of the first two permutations, i.e. 1 2 0.

from blasfeo.

lammev avatar lammev commented on June 11, 2024

Hello Gianluca,

Thank you for the feedback. To avoid confusion: the output I obtain is 0 2 1 as well, so the same as you. I however expect to get 1 2 0 as the correct result. If 0 2 1 is the expected output, could you clarify what the function is exactly supposed to do?

Thank you,
Lander

from blasfeo.

giaf avatar giaf commented on June 11, 2024

Hi Lander,

the routine uses the encoding of a permutation vector ipiv that is found e.g. in the standard LAPACK routine dgetrf for LU factorization (with the only difference that in LAPACK the indexes start from 1, while in BLASFEO I preferred to use the C standard array indexing of starting from 0, so it is exactly the standard LAPACK encoding minus one).

ipiv = [1, 2, 0] means (if applied to a vector):

  • swap element 0 of the original vector with the element at ipiv[0]=1
  • afterwards, swap element 1 of the output vector from the previous step with the element at ipiv[1]=2
  • afterwards, swap element 2 of the output vector from the previous step with the element at ipiv[2]=0

from blasfeo.

lammev avatar lammev commented on June 11, 2024

Dear Gianluca,

Thanks a lot for the explanation. I misunderstood the purpose of the function.

Kind regards,
Lander

from blasfeo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.