Git Product home page Git Product logo

Comments (9)

emberian avatar emberian commented on August 25, 2024

This is going to involve some heavy refactoring, and I think it should wait until Rust has associated types. The problem is that the BackEnd implementation conceptually defines all of the types that are needed to interact with it, but the trait itself lives in device. So, device needs types from the backend, the backend needs the trait from device... it's more than the trait, though, it's most of the API. Without associated types, can't make any progress.

from gfx.

brendanzab avatar brendanzab commented on August 25, 2024

Could we create a mocked up trait specification to allow us to transition in the future?

from gfx.

emberian avatar emberian commented on August 25, 2024

@bjz I believe this is done, currently.

from gfx.

brendanzab avatar brendanzab commented on August 25, 2024

It isn't - it is currently in a separate directory, but not actually a separate crate: https://github.com/gfx-rs/gfx-rs/blob/master/src/device/lib.rs#L43

from gfx.

emberian avatar emberian commented on August 25, 2024

Ah, yes.

from gfx.

kvark avatar kvark commented on August 25, 2024

@bjz I believe you are working on this one?
Edit: is it still blocked?

from gfx.

brendanzab avatar brendanzab commented on August 25, 2024

I was working on it, but was blocked by the associated item stuff.

from gfx.

kvark avatar kvark commented on August 25, 2024

Posting your comment, assuming it was about this issue:

Arg, trying to get associated types working with handles
but I am running into issues
I end up needing to pass the Device as a type parameter around
and the CommandBuffer trait needs the handle types
so CommandBuffer needs Device as a type parameter
but that ends in type checker recursion and blowing up rustc's stack
😔

from gfx.

kvark avatar kvark commented on August 25, 2024

@bjz So you are running into a type dependency recursion? Come back to gitter, when you have a moment, to share more info. Perhaps, you could push your branch for me to check out.

from gfx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.