HTTP_HOST undefined when running from command line about sentry-php HOT 7 CLOSED

I would suggest the more readable PHP_SAPI === 'cli' approach to check for the CLI environment. :-)
Not that I'm in charge of something here. ;-)

from sentry-php.

@xrstf PHP_SAPI isnt accurate in all cases (I think we used to use that)

from sentry-php.

Can you give an example on when PHP_SAPI is incorrect? I really can't think of any and checking for some random key in $_SERVER seems so hackish to me :-/

from sentry-php.

Unfortunately we seem to be awful about recording this kind of stuff, but the commit that changed it is

f27fd0a

And originally we introduced PHP_SAPI in

9fdff4b

On Wednesday, September 11, 2013 at 8:01 PM, Christoph wrote:

Can you give an example on when PHP_SAPI is incorrect? I really can't think of any and checking for some random key in $_SERVER seems so hackish to me :-/

—
Reply to this email directly or view it on GitHub (https://github.com/getsentry/raven-php/issues/113#issuecomment-24230936).

from sentry-php.

Actually whats the issue here? It's only using this to check for HTTP data AFAIK.

from sentry-php.

The problem is that checking for REQUEST_URI, doesn't guarantee that it is running from the command line. So when running a command line script, and raven catches an error, it ends up trying to reconstruct the request URL, tries to read HTTP_HOST, which in turns throws a new error (because it isn't defined).

from sentry-php.

Looks like this was fixed in c27fe51, if the problem persists please open a new issue.

from sentry-php.