Linux build with native SDK and GLIBC 2.27 about sentry-native HOT 8 CLOSED

https://bugs.chromium.org/p/crashpad/issues/detail?id=339

from sentry-native.

So in particular, this is about the following code in crashpad, which has a comment about why it can't check the GLIBC version:

https://github.com/getsentry/crashpad/blob/2fb4e9e6a4328ed49b15eec0a848fcc646208840/compat/linux/sys/mman.h#L22-L38

Rather than checking the version, it seems to be enough to actually add the throw() bit in the .cc file, to get it to compile at least (I haven't tested the resulting binary).

from sentry-native.

I think the right fix here would be to make sure the throw specified is on there for C++. I'm just not sure if all glibc versions have that or if that then breaks it for other setups.

from sentry-native.

I will close this for now, as this is specific to crashpad on linux, which we do not yet support. We will revisit this in a few weeks after we have breakpad support ready.

from sentry-native.

This is only a problem with a recent clang in c++17 mode as both clang -std=c++14 and GCC (I only tried c++17) seem to work fine.

The workaround thus is the following:

if (LINUX AND CLANG)  # <- pseudocode
    set_property(
        SOURCE /path/to/crashpad/compat/linux/sys/mman.cc
        APPEND PROPERTY COMPILE_FLAGS "-std=c++14"
    )
endif()

I'm using cmake files generated by a slightly modified version of gn_to_cmake.py on windows, darwin and linux without any problems. The above should come right after include()'ing the generated CMakeFiles.ext file.

from sentry-native.

gn_to_cmake.py

oh nice! I wish I knew about that one before

from sentry-native.

I dug a bit more: glibc-2.26 does not have this function. glibc-2.27 and later has it, always with __THROW in the declaration. __THROW is a glibc macro which compiles to nothing for gcc and select (very old) g++ versions.

If it's desired to avoid preprocessor checks, one can check with cmake (or gn) to see whether this function exists and compile mman.cc selectively.

from sentry-native.

The right thing to do is to patch crashpad to have __THROW in both declaration and definition of the said function as that's what it's trying to imitate here. Checking for glibc version is the wrong approach imo.

from sentry-native.