Git Product home page Git Product logo

Comments (4)

mitsuhiko avatar mitsuhiko commented on August 17, 2024

Is your idea to just defer the uploader or also to put the entire crash collection behind the consent prompt? We maintain patches to crashpad on our own repo here so you can also send a PR there: https://github.com/getsentry/crashpad/

from sentry-native.

mitsuhiko avatar mitsuhiko commented on August 17, 2024

I added basic support in #116 but I want to see if the flow can be improved.

from sentry-native.

icedtoast avatar icedtoast commented on August 17, 2024

Thanks, yes the idea is just defer uploading until consent is given.

#116 is close to what I have, although it is "global", where I was wanting support for asking consent on a per-report basis. I implemented this passing a path to a DLL which crashpad would load and then call before uploading each report.

Would that style (per-report consent) be something you were wanting to implement?
I'll have to rework my patchset in light of #116, but if you are already working in this area I'm happy to drop my local changes in favor of your solution.

from sentry-native.

mitsuhiko avatar mitsuhiko commented on August 17, 2024

I think it would be nice to have this on a per-report basis somehow. The main problem is that since crashpad is out of process and everything else is in process it's kinda ugly to find a backend independent implementation for that.

Would be very happy to accept something though that makes it possible.

from sentry-native.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.