Git Product home page Git Product logo

Comments (6)

wlach avatar wlach commented on May 16, 2024 2

Yeah, it's a bit unfortunate -- I assume the alembic db migrations were automatically generated, and were just wrong in this case. I think we need to verify (via pg_dump or similar) that the schema is as you'd expect after an arbitrary number of upgrades and downgrades.

FWIW my testing setup is to do this to downgrade:

./manage.py db downgrade fd4fc850d7ea

And this to upgrade:

./manage.py db upgrade

from redash.

wlach avatar wlach commented on May 16, 2024 1

Found an additional gotcha (schedule for queries can get set to the string "null" on downgrade), updated description.

from redash.

AndrewChubatiuk avatar AndrewChubatiuk commented on May 16, 2024

@wlach thanks for a finding
could you please submit PR with a fix?

from redash.

wlach avatar wlach commented on May 16, 2024

@wlach thanks for a finding could you please submit PR with a fix?

Will see what I can do.

from redash.

justinclift avatar justinclift commented on May 16, 2024

Oh, this all doesn't sound good.

Breaking the schema when downgrading is something we'd better fix.

The rough plan is to enable automatic schema upgrades when Redash starts (rather than a manual process). So being able to downgrade stuff when needed for some reason is probably pretty important.

from redash.

wlach avatar wlach commented on May 16, 2024

@wlach thanks for a finding could you please submit PR with a fix?

Will see what I can do.

Update: I haven't had time to look at this and am not sure when I will.

from redash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.